Skip to content

Update SDL to 2.30.9 (OpenRA-SDL2-CS 1.0.41) - #21644

Merged
penev92 merged 1 commit into
OpenRA:bleedfrom
PunkPun:update-sdl
Nov 16, 2024
Merged

penev92 merged 1 commit into
OpenRA:bleedfrom
PunkPun:update-sdl

Conversation

@PunkPun

@PunkPun PunkPun commented Nov 15, 2024 •

Copy link
Copy Markdown
Member

Nuget dependency OpenRA/SDL2-CS#20

@PunkPun
PunkPun marked this pull request as ready for review November 16, 2024 14:59
@PunkPun PunkPun changed the title Fix newer versions of SDL freezing when moving the game window Update SDL Nov 16, 2024
Mailaender
Mailaender previously approved these changes Nov 16, 2024

@Mailaender Mailaender left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Linux

Comment thread OpenRA.Platforms.Default/Sdl2PlatformWindow.cs Outdated
Comment thread OpenRA.Platforms.Default/Sdl2PlatformWindow.cs Outdated
@pchote

pchote commented Nov 16, 2024 •

Copy link
Copy Markdown
Member

It should be possible to use the new SDL_GetWindowSizeInPixels function to unify the window scale handling between macOS and linux/windows. This may also solve the issues with scaling under wayland.

@PunkPun
PunkPun force-pushed the update-sdl branch 2 times, most recently from c216789 to 7e6dc78 Compare November 16, 2024 17:49

@penev92 penev92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@penev92
penev92 merged commit 7d9aa58 into OpenRA:bleed Nov 16, 2024
@PunkPun
PunkPun deleted the update-sdl branch November 16, 2024 17:55
@penev92 penev92 changed the title Update SDL Update SDL to 2.30.9 (OpenRA-SDL2-CS 1.0.41) Nov 16, 2024
@penev92

penev92 commented Nov 16, 2024

Copy link
Copy Markdown
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants