Fix D2k "missing" music and movies - #21651
Merged
Merged
Conversation
pchote
reviewed
Nov 17, 2024
pchote
left a comment
pchote
left a comment
Member
There was a problem hiding this comment.
A couple of very minor comments, otherwise LGTM.
An oversight from PR 21598.
Mostly superficial, but in case of file name collisions we want the mod-specific files to override the common ones.
penev92
force-pushed
the
fixD2kAssets
branch
from
December 14, 2024 18:05
81571ca to
81a9bf9
Compare
Member
Author
|
Updated. |
pchote
approved these changes
Dec 21, 2024
pchote
left a comment
pchote
left a comment
Member
There was a problem hiding this comment.
Not 100% convinced about the Packages → SystemPackages rename, but that isn't worth holding things up over.
Member
Author
|
I'll take that as an official @pchote seal of approval. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported on Discord on
playtest-20241116.Closes #21658.