Skip to content

Fix unrelated CVE warnings#21657

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
Mailaender:net-9-cve-scanning
Nov 30, 2024
Merged

Fix unrelated CVE warnings#21657
PunkPun merged 1 commit into
OpenRA:bleedfrom
Mailaender:net-9-cve-scanning

Conversation

@Mailaender
Copy link
Copy Markdown
Member

that happen because .NET changed <NuGetAuditMode> to all. See https://github.com/OpenHV/OpenHV/actions/runs/11987849692/job/33422489150 for example.

@Mailaender Mailaender marked this pull request as ready for review November 23, 2024 19:48
@RoosterDragon
Copy link
Copy Markdown
Member

Do you still get warnings after updating the package but using the new mode? It seems valuable to use the new setting if we can.

@Mailaender
Copy link
Copy Markdown
Member Author

You mean I should skip d866823?

@RoosterDragon
Copy link
Copy Markdown
Member

You mean I should skip d866823?

Yes, I think getting these warnings is valuable.

@Mailaender
Copy link
Copy Markdown
Member Author

Okay. Kept the audit mode covering also indirect dependencies. This is not fixable downstream because the setting is at project level. OpenHV/OpenHV#1231 solved it by downgrading Windows and therefore the .NET version.

@michaeldgg2
Copy link
Copy Markdown
Contributor

michaeldgg2 commented Nov 24, 2024

If newer version of the SDK is bothering you, you can force different in global.json, you don't have to downgrade entire Windows version because of that.

https://learn.microsoft.com/en-us/dotnet/core/tools/global-json

@Mailaender
Copy link
Copy Markdown
Member Author

I haven't tried that, but I assume that would only change the targeted SDK not the default setting of <NuGetAuditMode> as .NET 9 would still be responsible for the compilation.

@michaeldgg2
Copy link
Copy Markdown
Contributor

No, if you force a specific version of SDK via global.json, you need to have that version installed, otherwise the .NET CLI command will fail to run (taking into account rollForward configuration of course).

In CI (continuous integration) scenarios, however, you typically want to specify an acceptable range for the SDK version that is used. The global.json file has a rollForward feature that provides flexible ways to specify an acceptable range of versions.

@PunkPun PunkPun merged commit 7987505 into OpenRA:bleed Nov 30, 2024
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Nov 30, 2024

changelog

@Mailaender Mailaender deleted the net-9-cve-scanning branch November 30, 2024 17:17
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Dec 2, 2024

changelog

f316d4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants