Skip to content

Fix harvesters refusing to allow queuing up docking orders when invalid#21662

Merged
penev92 merged 2 commits into
OpenRA:bleedfrom
PunkPun:dock
Dec 27, 2024
Merged

Fix harvesters refusing to allow queuing up docking orders when invalid#21662
penev92 merged 2 commits into
OpenRA:bleedfrom
PunkPun:dock

Conversation

@PunkPun
Copy link
Copy Markdown
Member

@PunkPun PunkPun commented Dec 2, 2024

It's a bug as by the time the queued dock order could be played as an activity, it might have become valid

Reported on discord

@penev92
Copy link
Copy Markdown
Member

penev92 commented Dec 11, 2024

The original report: message

penev92
penev92 previously approved these changes Dec 26, 2024
Copy link
Copy Markdown
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that small naming thing.

Comment thread OpenRA.Mods.Common/Activities/MoveToDock.cs Outdated
Copy link
Copy Markdown
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost how I wanted it

@penev92 penev92 merged commit d9cfb2c into OpenRA:bleed Dec 27, 2024
@penev92
Copy link
Copy Markdown
Member

penev92 commented Dec 27, 2024

Changelog

Commits on prep-2411:
52102da
2ccfa42

@PunkPun PunkPun deleted the dock branch December 27, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants