Reduce the size of battlefield news when messages are short#21672
Merged
Conversation
Member
|
Top spacing seems to be bigger than the bottom spacing. Feels like it should have some more at the bottom. |
Member
Author
|
that's an optical illusion. I dunno what is the cleanest way to address it apart from rewriting out box model |
Member
|
I think something as simple as -newsPanel.Bounds.Height = Math.Min(newsPanel.ContentHeight, maxNewsHeight);
+newsPanel.Bounds.Height = Math.Min(newsPanel.ContentHeight + 5, maxNewsHeight);makes it look better (despite not being the greatest solution out there). |
PunkPun
force-pushed
the
fix-battlefield-news
branch
from
December 19, 2024 15:35
5ec8b68 to
37fffc2
Compare
penev92
approved these changes
Dec 19, 2024
penev92
left a comment
penev92
left a comment
Member
There was a problem hiding this comment.
Alright, not an important deal anyway.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bleed
Suggested