Skip to content

Add delete button to the map editor - #21677

Merged
penev92 merged 2 commits into
OpenRA:bleedfrom
PunkPun:delete
Dec 20, 2024
Merged

Add delete button to the map editor#21677
penev92 merged 2 commits into
OpenRA:bleedfrom
PunkPun:delete

Conversation

@PunkPun

@PunkPun PunkPun commented Dec 20, 2024

Copy link
Copy Markdown
Member

Fixes #21671

Also added delete hotkey

@penev92 penev92 added this to the Next Release milestone Dec 20, 2024
@PunkPun
PunkPun force-pushed the delete branch 3 times, most recently from 1c55471 to 8c43e1a Compare December 20, 2024 19:02

@penev92 penev92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise 👍

Comment thread mods/common/fluent/chrome.ftl Outdated
label-selected-area-diagonal = Diagonal:
label-selected-area-resources = Resources:
label-copy-filters = Copy Filters
label-copy-filters = Filters

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label-copy-filters = Filters
label-selection-filters = Filters

perhaps? Might be good for the 3 separate filters below as well.

pasteButton.IsHighlighted = () => editor.CurrentBrush is EditorCopyPasteBrush;

var deleteAreaSelectionButton = areaEditPanel.Get<ButtonWidget>("SELECTION_DELETE_BUTTON");
deleteAreaSelectionButton.OnClick = () => editor.DefaultBrush.DeleteSelection(copyFilters);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deleteAreaSelectionButton.OnClick = () => editor.DefaultBrush.DeleteSelection(copyFilters);
deleteAreaSelectionButton.OnClick = () => editor.DefaultBrush.DeleteSelection(selectionFilters);

@penev92 penev92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@penev92
penev92 merged commit 269542c into OpenRA:bleed Dec 20, 2024
@PunkPun
PunkPun deleted the delete branch December 20, 2024 21:58
@penev92

penev92 commented Dec 20, 2024

Copy link
Copy Markdown
Member

Changelog

Commits on prep-2411:
c561509
3fa2b9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Delete in Map Editor

2 participants