Don't bind bogus Location or Facing lua properties for actors without Location or Facing#21684
Merged
PunkPun merged 2 commits intoOpenRA:bleedfrom Jan 15, 2025
Merged
Don't bind bogus Location or Facing lua properties for actors without Location or Facing#21684PunkPun merged 2 commits intoOpenRA:bleedfrom
PunkPun merged 2 commits intoOpenRA:bleedfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue brought up on Discord where
HasPropertyreturns true but the script crashes when they are used on e.g. the player actor.Testcase: add the following to the bottom of the RA shellmap's
WorldLoadedfunction:Note: Similar changes really should be done for the other methods/properties in
GeneralProperties, but those would be breaking API changes, so I don't want to deal with them here.