Fix ordos-04 to use internal bot names#21708
Merged
Merged
Conversation
PunkPun
approved these changes
Jan 16, 2025
PunkPun
left a comment
PunkPun
left a comment
Member
There was a problem hiding this comment.
This fix works, but ideally, we should change these datastructures to not use faction names as table keys, instead have a table per faction
Member
Member
Member
I don't think that would work as a good chunk of the later missions has multiple AI players per faction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21706
The script on bleed/playtest expects certain names from bot players but those are different ("Smugglers" -> "Campaign Player AI 2") since bot names were exposed to localization. This PR changes the script to use the internal names.
There is something similar happening with the tooltip for the modified Outpost here and in
harkonnen-05. I'm less certain how that should be handled.The shellmap script makes use of localized bot names, but not in a way that seems to cause problems.