Skip to content

Re-add a mini lobby options menu to missionbrowser#21710

Merged
Mailaender merged 2 commits intoOpenRA:bleedfrom
PunkPun:options
Feb 16, 2025
Merged

Re-add a mini lobby options menu to missionbrowser#21710
Mailaender merged 2 commits intoOpenRA:bleedfrom
PunkPun:options

Conversation

@PunkPun
Copy link
Copy Markdown
Member

@PunkPun PunkPun commented Jan 17, 2025

Partially reverts #20934

I've been angry at that PR ever since it got merged. Hiding crucial information behind a click is not acceptable. I've still kept the lobby-style UI for missions that have more options available (f.e. openra specials)

Partially addresses #21698, when navigating the mission selector we remember speed and difficulty. Info is still destroyed on closing the menu

Screenshot 2025-01-17 at 13 27 02

Comment thread OpenRA.Mods.Common/Widgets/Logic/MissionBrowserLogic.cs Outdated
Comment thread OpenRA.Mods.Common/Widgets/Logic/MissionBrowserLogic.cs Outdated
Comment thread mods/cnc/chrome/missionbrowser.yaml Outdated
Comment thread mods/cnc/chrome/missionbrowser.yaml Outdated
@PunkPun PunkPun force-pushed the options branch 3 times, most recently from 5e05b66 to b951398 Compare February 10, 2025 20:47
@pchote
Copy link
Copy Markdown
Member

pchote commented Feb 10, 2025

The padding around the TD buttons is still off, notice in particular how they are not aligned with the bottom of the mission selection scroll panel:
Screenshot 2025-02-10 at 21 18 01

Compare to the original layout which had more padding above and below:
Screenshot 2025-02-10 at 21 18 28

@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented Feb 10, 2025

sure, I had tried centering instead of alligning with the bottom panel

readonly string defaultTooltop;

// For remembering options
// TODO: this should be persistent across game sessions
Copy link
Copy Markdown
Member

@pchote pchote Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21206 can be extended to save a "missions.{mod}.yaml" as an interim solution until there is proper campaign-related state.

IMO it shouldn't be done in this pr, but it ideally would be done for this upcoming release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree #21698

dropdown-difficulty =
.label = Difficulty
.description = The difficulty of the mission.
.description = The difficulty of the mission
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point i've given up understanding whether tooltips should have full sentences or not...

Copy link
Copy Markdown
Member Author

@PunkPun PunkPun Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips have no ending punctuation except for a few exceptions. That is where we write whole paragraphs: unit desctiptions, faction descriptions, stance and command bar

@Mailaender Mailaender merged commit ebf9097 into OpenRA:bleed Feb 16, 2025
@Mailaender
Copy link
Copy Markdown
Member

Changelog

@Mailaender
Copy link
Copy Markdown
Member

38d4719

@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented Feb 16, 2025

and 70bb01a

@PunkPun PunkPun deleted the options branch February 16, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants