Re-add a mini lobby options menu to missionbrowser#21710
Merged
Mailaender merged 2 commits intoOpenRA:bleedfrom Feb 16, 2025
Merged
Re-add a mini lobby options menu to missionbrowser#21710Mailaender merged 2 commits intoOpenRA:bleedfrom
Mailaender merged 2 commits intoOpenRA:bleedfrom
Conversation
pchote
reviewed
Feb 8, 2025
pchote
reviewed
Feb 8, 2025
5e05b66 to
b951398
Compare
Member
Member
Author
|
sure, I had tried centering instead of alligning with the bottom panel |
pchote
reviewed
Feb 11, 2025
| readonly string defaultTooltop; | ||
|
|
||
| // For remembering options | ||
| // TODO: this should be persistent across game sessions |
Member
There was a problem hiding this comment.
#21206 can be extended to save a "missions.{mod}.yaml" as an interim solution until there is proper campaign-related state.
IMO it shouldn't be done in this pr, but it ideally would be done for this upcoming release.
| dropdown-difficulty = | ||
| .label = Difficulty | ||
| .description = The difficulty of the mission. | ||
| .description = The difficulty of the mission |
Member
There was a problem hiding this comment.
At this point i've given up understanding whether tooltips should have full sentences or not...
Member
Author
There was a problem hiding this comment.
Tooltips have no ending punctuation except for a few exceptions. That is where we write whole paragraphs: unit desctiptions, faction descriptions, stance and command bar
pchote
approved these changes
Feb 14, 2025
Member
Member
Member
Author
|
and 70bb01a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Partially reverts #20934
I've been angry at that PR ever since it got merged. Hiding crucial information behind a click is not acceptable. I've still kept the lobby-style UI for missions that have more options available (f.e. openra specials)
Partially addresses #21698, when navigating the mission selector we remember speed and difficulty. Info is still destroyed on closing the menu