Skip to content

Restore StartGameNotification in missions#21725

Merged
PunkPun merged 1 commit into
OpenRA:bleedfrom
JovialFeline:restore-start-notification
Jan 28, 2025
Merged

Restore StartGameNotification in missions#21725
PunkPun merged 1 commit into
OpenRA:bleedfrom
JovialFeline:restore-start-notification

Conversation

@JovialFeline
Copy link
Copy Markdown
Contributor

@JovialFeline JovialFeline commented Jan 28, 2025

A tiny step toward #21711

StartGameNotification is incorrectly removed in two missions so a sound takes the normal start notification's place in the mission script. This PR still skips the sound while preserving other notifications like save/load ones.

Copy link
Copy Markdown
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit 55787fb into OpenRA:bleed Jan 28, 2025
@PunkPun
Copy link
Copy Markdown
Member

PunkPun commented Jan 28, 2025

changelog

0ac28e1

@PunkPun PunkPun added this to the Next Release milestone Jan 28, 2025
@JovialFeline JovialFeline deleted the restore-start-notification branch March 21, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants