Merged
Conversation
PunkPun
reviewed
Feb 8, 2025
|
|
||
| [Desc("Call a function when one of the actors in a group is killed. The callback " + | ||
| [Desc("Call a function when one of the actors in a group is killed. " + | ||
| "This trigger removes itself once activated. The callback " + |
Member
There was a problem hiding this comment.
I think both of these are incorrect. The triggers are never removed, but rather they are deactivated. Maybe better wording would be, the trigger is called only once?
Contributor
Author
There was a problem hiding this comment.
Makes sense. Done.
JovialFeline
force-pushed
the
clarify-lua
branch
from
80fab9d to
95483e8
Compare
RoosterDragon
approved these changes
Feb 8, 2025
PunkPun
approved these changes
Feb 8, 2025
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds details to the Lua documentation that are not obvious without testing or looking at the underlying C# code.
There is also a minor annoyance with OnProduction and OnCapture that I'd like to fix.