Fix a bad comparison against Target.Invalid.#21742
Merged
pchote merged 1 commit intoOpenRA:bleedfrom Feb 15, 2025
Merged
Conversation
Target.Invalid acts like a NaN, and will not compare equal with itself. Compare against the TargetType instead, which performs the intended comparison.
pchote
approved these changes
Feb 11, 2025
Member
pchote
left a comment
pchote
left a comment
There was a problem hiding this comment.
Not tested, but clearly correct.
Member
|
related: #21736 |
Contributor
|
Wouldn't i just have been a |
Contributor
Or perhaps elsewhere you also create an instance with type invalid. |
Member
Author
|
|
Contributor
I see. Since it's a struct thereby a value type it is an instance and not a null pointer. Mixing languages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target.Invalid acts like a NaN, and will not compare equal with itself. Compare against the TargetType instead, which performs the intended comparison.