Repository navigation
Sanitize saved skirmish factions. - #21756
Merged
Merged
Conversation
RoosterDragon
approved these changes
Feb 22, 2025
Member
Author
|
Updated. |
pchote
commented
Feb 22, 2025
| if (!isValidFaction) | ||
| { | ||
| server.SendFluentMessageTo(conn, InvalidFactionSelected, new object[] { "faction", faction }); | ||
| server.SendFluentMessageTo(conn, SupportedFactions, new object[] { "factions", factions.JoinWith(", ") }); |
Member
Author
There was a problem hiding this comment.
We don't report these for any of the other options, and this info isn't very useful for the client - so better removed.
PunkPun
reviewed
Feb 22, 2025
pchote
force-pushed
the
fix-skirmish-options-faction
branch
from
February 22, 2025 12:57
861fa5c to
376dbaa
Compare
Member
Author
|
Reworked to handle bots and reduce duplication. |
PunkPun
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash reported on Discord.
Testcase: edit the
skirmish.{mod}.yamlfile and set bogus values. The existing logic already handled bogus options, but no checking was done for faction names.