Desura compatibilty #2813

Merged
merged 4 commits into from Mar 26, 2013

Projects

None yet

3 participants

@Mailaender
Owner

You currently can't install/start OpenRA on the Desurium Linux client on. To fix this we are currently unpublished from http://www.desura.com/games/openra by DesuraNET staff. I already tweaked the install settings and prepared this patch for OpenRA. I do the MCF generation from a fresh install of an RPM from /usr/share/openra for Linux and NSIS Setup.exe from Program Files/OpenRA for Windows. Left some documentation on https://github.com/lodle/Desurium/wiki/Notes-For-Publishing-On-Desura because it is quirky.

Mailaender added some commits Mar 21, 2013
@Mailaender Mailaender Desura compatibility
- create launch scripts for Desura
- that access local installation launch scripts
- clean up /usr/* launch scripts created during make install
28d740d
@Mailaender Mailaender recommend Cg-Toolkit as soft dependency for Fedora/SUSE
it is in the non-free / RPMfusion repositories
2d62007
@hasufell

bashism, use ". desura_prelaunch.sh " instead

@hasufell

safer to use ${foo} instead of $foo here

You don't need to duplicate this in the args/no-args cases.

@hasufell

bashism, use ". desura_prelaunch.sh " instead

@hasufell

use /bin/sh and fix the mentioned bashisms

Is there actually any win to not requiring bash?

First: The script is not strictly bash syntax which means it's a mix of bash and posix. That means we rely on the compatibility layer of bash to solve that situation which is not optimal.
Second: It's a portability improvement and will allow users to run those scripts in their native shell which is always an improvement. Given the trivial changes this requires I don't even see a reason to debate this.

@hasufell

use /bin/sh and fix the mentioned bashisms

@hasufell

safer to use ${foo} instead of $foo here

@hasufell

Although this is posix, we can make it compatible with tcsh, by doing:
http://slexy.org/view/s2lvoxOymw

@hasufell

Although this is posix, we can make it compatible with tcsh, by doing:
http://slexy.org/view/s2lvoxOymw

@hasufell

This seems crap indeed, I cannot believe that something like this is actually necessary.

Owner

See https://github.com/lodle/Desurium/issues/523 for the upstream issue.

Owner

Thanks for the review @hasufell.

@chrisforbes

This is absolutely horrid.

Owner

I will be happy when someone points out how to avoid this, but fear this is how today's games digital distribution clients workaround the variety of package managers and dependency hell on Linux. :/

Owner

I am not really happy with it, but to properly test it I need it in a playtest and it is better than no Linux branch on Desura. @hasufell will bug me whenever I log into my instant messenger :P

@Mailaender Mailaender merged commit 0ab57c9 into OpenRA:bleed Mar 26, 2013

1 check passed

default The Travis build passed
Details
@Mailaender Mailaender deleted the Mailaender:desura branch May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment