Added OpenAL and SDL Windows dependency DLLs to mirrors #3281

Merged
merged 1 commit into from May 16, 2013

Conversation

Projects
None yet
3 participants
@Mailaender
Owner

Mailaender commented May 13, 2013

This fixes https://github.com/OpenRA/OpenRA/wiki/FAQ#the-downloads-during-windows-installation-and-first-game-start-dont-work as it is a common annoyance that the SDL/OpenAL webserver went down when somebody tried to run the OpenRA Setup.exe only this time it happened during the first minutes after the stable release announcement when I tried to prepare the patch for Desura which required a clean install so I noticed when a file got removed in my proposed patch there and could help people immediately. http://www.libsdl.org/ was online again after a short while so this is not urgent.

@pchote

This comment has been minimized.

Show comment Hide comment
@pchote

pchote May 15, 2013

Owner

To fix this properly the installer should also abort the installation if the fetch fails.

Owner

pchote commented May 15, 2013

To fix this properly the installer should also abort the installation if the fetch fails.

@Mailaender

This comment has been minimized.

Show comment Hide comment
@Mailaender

Mailaender May 15, 2013

Owner

It already does which is annoying if there is only 1 mirror and that one is down.

Owner

Mailaender commented May 15, 2013

It already does which is annoying if there is only 1 mirror and that one is down.

@pchote

This comment has been minimized.

Show comment Hide comment
@pchote

pchote May 15, 2013

Owner

When I say abort, I mean roll back the installation so you don't leave a broken game.

Owner

pchote commented May 15, 2013

When I say abort, I mean roll back the installation so you don't leave a broken game.

@Mailaender

This comment has been minimized.

Show comment Hide comment
@Mailaender

Mailaender May 15, 2013

Owner

I wondered why it left a broken game in my case. Usually it will fail and clean up everything that is already installed. Someone on Desura commented that it is braindead to not bundle the dependencies and download them live as this is very likely to break. My attempt to fix this will use the same NSIS macro everywhere (which seems to retry and abort/clean) and use the OpenRA mirror system which is in our control.

Owner

Mailaender commented May 15, 2013

I wondered why it left a broken game in my case. Usually it will fail and clean up everything that is already installed. Someone on Desura commented that it is braindead to not bundle the dependencies and download them live as this is very likely to break. My attempt to fix this will use the same NSIS macro everywhere (which seems to retry and abort/clean) and use the OpenRA mirror system which is in our control.

@chrisforbes

This comment has been minimized.

Show comment Hide comment
@chrisforbes

chrisforbes May 16, 2013

Owner

Have you deployed the mirrorlist setup for this to the live site?

Owner

chrisforbes commented May 16, 2013

Have you deployed the mirrorlist setup for this to the live site?

@Mailaender

This comment has been minimized.

Show comment Hide comment
@Mailaender

Mailaender May 16, 2013

Owner

Yes, before making this pull request. Otherwise I could not test if this works.

Owner

Mailaender commented May 16, 2013

Yes, before making this pull request. Otherwise I could not test if this works.

chrisforbes added a commit that referenced this pull request May 16, 2013

Merge pull request #3281 from Mailaender/sdl-openal-mirrors
Added OpenAL and SDL Windows dependency DLLs to mirrors

@chrisforbes chrisforbes merged commit 56067e4 into OpenRA:bleed May 16, 2013

1 check passed

default The Travis CI build passed
Details

@Mailaender Mailaender deleted the Mailaender:sdl-openal-mirrors branch May 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment