Add Guard and AttackMove to RA and C&C aircraft. #4478

Merged
merged 12 commits into from Feb 1, 2014

Projects

None yet

4 participants

@pchote
OpenRA member

No description provided.

@chrisforbes
OpenRA member

👍; needs testing though.

@Phrohdoh
OpenRA member

Works as expected for me. The only thing I noticed was the helis seem to bob up and down violently when traveling, not sure if this is the cause or if that has been present in the past.

@Mailaender
OpenRA member

This breaks @ScottNZ's allies01-classic Lua mission which features a helicopter insertion:
NLua.Exceptions.LuaScriptException: [string "mods/common/lua/openra.lua"]:9: A .NET exception occured in user-code

@Mailaender
OpenRA member

Guard does not actually work with heli/aircraft in RA. I get a blocked cursor.

@pchote
OpenRA member

@Mailaender: This lets aircraft guard other units, but not the other way around.

@Mailaender
OpenRA member

Okay, that was my mistake. However you still get a 👎 for the Lua breakage. Sadly I have no idea what needs to be changed. The Lua standard library is not really easily maintainable in this state because of #4385 and because CI does not check those scripts. Maybe some functions with complex engine logic should move to C# and only interfaces should be exposed in .lua files.

@pchote
OpenRA member

Rebased, fixed lua breakage, and made aircraft guardable by other units.

@Mailaender
OpenRA member

Needs a rebase probably because of the changelog.

@pchote
OpenRA member

Rebased.

@Mailaender Mailaender merged commit e4effd0 into OpenRA:bleed Feb 1, 2014

1 check passed

Details default The Travis CI build passed
@Mailaender
OpenRA member

We can simplify the aircraft and AI special case now.

@pchote pchote deleted the pchote:aircraft-follow branch Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment