New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all cheat code #7507

Merged
merged 1 commit into from Feb 22, 2015

Conversation

Projects
None yet
7 participants
@pevers
Contributor

pevers commented Feb 20, 2015

Polished #7505 to activate all cheat codes on call and reset all on call.

@Unit158

This comment has been minimized.

Show comment
Hide comment
@Unit158

Unit158 Feb 20, 2015

Contributor

👎 This now limits the /all cheat to Developer Mode cheats.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff

Reply to this email directly or view it on GitHub.

Contributor

Unit158 commented Feb 20, 2015

👎 This now limits the /all cheat to Developer Mode cheats.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff

Reply to this email directly or view it on GitHub.

@Unit158

This comment has been minimized.

Show comment
Hide comment
@Unit158

Unit158 Feb 20, 2015

Contributor

Actually, that could be fixed in other ways. You need to make sure that all the effects from the cheats that it previously activated are still activated, however.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff

Reply to this email directly or view it on GitHub.

Contributor

Unit158 commented Feb 20, 2015

Actually, that could be fixed in other ways. You need to make sure that all the effects from the cheats that it previously activated are still activated, however.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff

Reply to this email directly or view it on GitHub.

@pevers

This comment has been minimized.

Show comment
Hide comment
@pevers

pevers Feb 20, 2015

Contributor

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?

Contributor

pevers commented Feb 20, 2015

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Feb 20, 2015

Member

This looks like a good idea, but I haven't tested it yet. #7505 has always annoyed me.

Member

pchote commented Feb 20, 2015

This looks like a good idea, but I haven't tested it yet. #7505 has always annoyed me.

@Unit158

This comment has been minimized.

Show comment
Hide comment
@Unit158

Unit158 Feb 20, 2015

Contributor

Disregard my first comment; I misunderstood the code. My problem is that /all doesn't currently activate the effect of DevGiveCash or DevLevelUp. I just like having the extra cash after calling /all. In any case, +1

On 2015-02-20, at 5:31 AM, Peter Evers notifications@github.com wrote:

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?


Reply to this email directly or view it on GitHub.

Contributor

Unit158 commented Feb 20, 2015

Disregard my first comment; I misunderstood the code. My problem is that /all doesn't currently activate the effect of DevGiveCash or DevLevelUp. I just like having the extra cash after calling /all. In any case, +1

On 2015-02-20, at 5:31 AM, Peter Evers notifications@github.com wrote:

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?


Reply to this email directly or view it on GitHub.

@pevers

This comment has been minimized.

Show comment
Hide comment
@pevers

pevers Feb 21, 2015

Contributor

I could add DevGiveCash and DevLevelUp too? I wasn't totally sure if I should add this or not.

Contributor

pevers commented Feb 21, 2015

I could add DevGiveCash and DevLevelUp too? I wasn't totally sure if I should add this or not.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Feb 21, 2015

Member

DevLevelUp doesn't make a lot of sense for this, since it requires you to have actors selected.

Member

pchote commented Feb 21, 2015

DevLevelUp doesn't make a lot of sense for this, since it requires you to have actors selected.

@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Feb 21, 2015

Contributor

👍 once DevGiveCash has been added

Contributor

obrakmann commented Feb 21, 2015

👍 once DevGiveCash has been added

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Feb 21, 2015

Member

I'd say give something like 100k cash in order to simplify things (just hardcode it) and squash the commits.

Member

penev92 commented Feb 21, 2015

I'd say give something like 100k cash in order to simplify things (just hardcode it) and squash the commits.

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Feb 21, 2015

Member

Let's not hardcode it.
It already has a default value.

Member

Phrohdoh commented Feb 21, 2015

Let's not hardcode it.
It already has a default value.

changed all cheat to really enable everything on call
added givecash to the all cheat

fixed spacing

fixed spacing
@pevers

This comment has been minimized.

Show comment
Hide comment
@pevers

pevers Feb 22, 2015

Contributor

The commits are now squashed.

Contributor

pevers commented Feb 22, 2015

The commits are now squashed.

obrakmann added a commit that referenced this pull request Feb 22, 2015

@obrakmann obrakmann merged commit 293ec65 into OpenRA:bleed Feb 22, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Feb 22, 2015

Contributor

Thanks!

Changelog

Contributor

obrakmann commented Feb 22, 2015

Thanks!

Changelog

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Feb 22, 2015

Member

The shroud is not disabled anymore when I type /all.

Member

Mailaender commented Feb 22, 2015

The shroud is not disabled anymore when I type /all.

@pevers

This comment has been minimized.

Show comment
Hide comment
@pevers

pevers Feb 22, 2015

Contributor

Oops, I missed that. Sorry, I'll open a PR.

Contributor

pevers commented Feb 22, 2015

Oops, I missed that. Sorry, I'll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment