New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kill/Death ratio in statistics window #7529

Merged
merged 1 commit into from Mar 20, 2015

Conversation

Projects
None yet
8 participants
@jabbink
Contributor

jabbink commented Feb 23, 2015

closes #6858

@jabbink

This comment has been minimized.

Show comment
Hide comment
@jabbink

jabbink Feb 23, 2015

Contributor

Renamed Widget to KD_RATIO and changed the calculation, which removed the if with the missing new line.

Contributor

jabbink commented Feb 23, 2015

Renamed Widget to KD_RATIO and changed the calculation, which removed the if with the missing new line.

@jabbink

This comment has been minimized.

Show comment
Hide comment
@jabbink

jabbink Feb 23, 2015

Contributor

Restored correct behaviour for the lambda functions again

Contributor

jabbink commented Feb 23, 2015

Restored correct behaviour for the lambda functions again

@Micr0Bit

This comment has been minimized.

Show comment
Hide comment
@Micr0Bit

Micr0Bit Feb 24, 2015

Member

just simple calling it "K/D" ... would be nicer imo ...

kd

Member

Micr0Bit commented Feb 24, 2015

just simple calling it "K/D" ... would be nicer imo ...

kd

@jabbink

This comment has been minimized.

Show comment
Hide comment
@jabbink

jabbink Mar 1, 2015

Contributor

Everyone agrees? Personally I think that if this changes to K/D (or KDR), Actions/min should also change to A/m (or APM).

Contributor

jabbink commented Mar 1, 2015

Everyone agrees? Personally I think that if this changes to K/D (or KDR), Actions/min should also change to A/m (or APM).

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Mar 1, 2015

Member

I actually like seeing raw statistics (where applicable) instead of ratios.

Member

Phrohdoh commented Mar 1, 2015

I actually like seeing raw statistics (where applicable) instead of ratios.

@chrisforbes

This comment has been minimized.

Show comment
Hide comment
@chrisforbes

chrisforbes Mar 1, 2015

Member

The raw kills/deaths numbers are still there.

One might argue that kills - deaths is more important in an RTS than KDR,
but... this is a number people understand now.

On Mon, Mar 2, 2015 at 5:50 AM, Taryn Hill notifications@github.com wrote:

I actually like seeing raw statistics (where applicable) instead of ratios.


Reply to this email directly or view it on GitHub
#7529 (comment).

Member

chrisforbes commented Mar 1, 2015

The raw kills/deaths numbers are still there.

One might argue that kills - deaths is more important in an RTS than KDR,
but... this is a number people understand now.

On Mon, Mar 2, 2015 at 5:50 AM, Taryn Hill notifications@github.com wrote:

I actually like seeing raw statistics (where applicable) instead of ratios.


Reply to this email directly or view it on GitHub
#7529 (comment).

@jabbink

This comment has been minimized.

Show comment
Hide comment
@jabbink

jabbink Mar 5, 2015

Contributor

Rebased.

Contributor

jabbink commented Mar 5, 2015

Rebased.

@penev92 penev92 removed the PR: Rebase me! label Mar 5, 2015

@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Mar 10, 2015

Contributor

Looks ok to me, works in both ra and td. 👍

Contributor

obrakmann commented Mar 10, 2015

Looks ok to me, works in both ra and td. 👍

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Mar 20, 2015

Member

Confirmed. Works as promised.

Member

Mailaender commented Mar 20, 2015

Confirmed. Works as promised.

Mailaender added a commit that referenced this pull request Mar 20, 2015

Merge pull request #7529 from delftswa2014/feature/kdr_stat
Add Kill/Death ratio in statistics window

@Mailaender Mailaender merged commit dc1862f into OpenRA:bleed Mar 20, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender
Member

Mailaender commented Mar 20, 2015

@jabbink jabbink deleted the delftswa2014:feature/kdr_stat branch Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment