New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically manage engine versions #14

Merged
merged 3 commits into from Jun 29, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Jun 25, 2017

Closes #7.

I would like to get a second/third set of eyes on this before merging – especially the Linux/macOS scripts, which I have reworked from the first version to follow the more sensible approach of @abcdefg30's powershell scripts.

@pchote pchote changed the title from Engine management to Automatically manage engine versions Jun 25, 2017

Show outdated Hide outdated launch-dedicated.sh Outdated
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 26, 2017

Member

Updated. Thinking about the makefile situation a bit more, I came to the conclusion that automatically fetching and building everything is unexpected and a bit rude. I have changed the launch scripts to instead prompt the user to run this step manually.

Member

pchote commented Jun 26, 2017

Updated. Thinking about the makefile situation a bit more, I came to the conclusion that automatically fetching and building everything is unexpected and a bit rude. I have changed the launch scripts to instead prompt the user to run this step manually.

Show outdated Hide outdated launch-game.cmd Outdated
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 27, 2017

Member

Updated.

Member

pchote commented Jun 27, 2017

Updated.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 28, 2017

Member

I am planning to merge this tomorrow evening if there are no more issues. Will be travelling friday/saturday and plan to tackle #13 and #8 while offline, which both depend on this being finished.

Member

pchote commented Jun 28, 2017

I am planning to merge this tomorrow evening if there are no more issues. Will be travelling friday/saturday and plan to tackle #13 and #8 while offline, which both depend on this being finished.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 28, 2017

I don't know if it's just on my end, but when running 'make all', I get a 'CommandNotFoundException' for Expand-Archive.

It also doesn't stop trying after that error, I have to close the window.

reaperrr commented Jun 28, 2017

I don't know if it's just on my end, but when running 'make all', I get a 'CommandNotFoundException' for Expand-Archive.

It also doesn't stop trying after that error, I have to close the window.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 28, 2017

Member

Looks like that command requires a newer version of powershell than you have. I will replace it with a different extraction technique.

Member

pchote commented Jun 28, 2017

Looks like that command requires a newer version of powershell than you have. I will replace it with a different extraction technique.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 28, 2017

Member

Updated. Please try again @reaperrr.

Member

pchote commented Jun 28, 2017

Updated. Please try again @reaperrr.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 28, 2017

Updated. Please try again @reaperrr.

Works now, the only remaining thing:
It first says Version set to foo, but then in the next line unknown command 'version'. The example mod launches fine, but after closing the example mod via Quit the command line window throws an error, because mod.yaml - Metadata.Version is still {DEV_VERSION}.

Failed to register currrent mod metadata
System.ArgumentException: Ein Element mit dem gleichen Schlüssel wurde bereits hinzugefügt.
   bei System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   bei System.Collections.Generic.Dictionary'2.Insert(TKey key, TValue value, Boolean add)
   bei System.Collections.Generic.Dictionary'2.Add(TKey key, TValue value)
   bei OpenRA.ExternalMods.LoadMod(MiniYaml yaml) in e:\ORA_ModTemplate1\engine\OpenRA.Game\ExternalMods.cs:Zeile 83.
   bei OpenRA.ExternalMods.Register(Manifest mod) in e:\ORA_ModTemplate1\engine\OpenRA.Game\ExternalMods.cs:Zeile 115.

reaperrr commented Jun 28, 2017

Updated. Please try again @reaperrr.

Works now, the only remaining thing:
It first says Version set to foo, but then in the next line unknown command 'version'. The example mod launches fine, but after closing the example mod via Quit the command line window throws an error, because mod.yaml - Metadata.Version is still {DEV_VERSION}.

Failed to register currrent mod metadata
System.ArgumentException: Ein Element mit dem gleichen Schlüssel wurde bereits hinzugefügt.
   bei System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   bei System.Collections.Generic.Dictionary'2.Insert(TKey key, TValue value, Boolean add)
   bei System.Collections.Generic.Dictionary'2.Add(TKey key, TValue value)
   bei OpenRA.ExternalMods.LoadMod(MiniYaml yaml) in e:\ORA_ModTemplate1\engine\OpenRA.Game\ExternalMods.cs:Zeile 83.
   bei OpenRA.ExternalMods.Register(Manifest mod) in e:\ORA_ModTemplate1\engine\OpenRA.Game\ExternalMods.cs:Zeile 115.
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jun 28, 2017

Member

It first says Version set to foo, but then in the next line unknown command 'version'.

This is probably the bug in the engine's make script and fixed by OpenRA/OpenRA#13359.

Member

abcdefg30 commented Jun 28, 2017

It first says Version set to foo, but then in the next line unknown command 'version'.

This is probably the bug in the engine's make script and fixed by OpenRA/OpenRA#13359.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 29, 2017

Member

Failed to register currrent mod metadata
System.ArgumentException:

This is another engine bug that is fixed by OpenRA/OpenRA#13367.
The typo in the error message is fixed by OpenRA/OpenRA#13539.

Member

pchote commented Jun 29, 2017

Failed to register currrent mod metadata
System.ArgumentException:

This is another engine bug that is fixed by OpenRA/OpenRA#13367.
The typo in the error message is fixed by OpenRA/OpenRA#13539.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 29, 2017

Tested again with fetching latest bleed, bug is gone 👍
I can't help with the Linux/macOS scripts, but on the Windows side things look mergable (maybe update last commit to fetch latest bleed before merging).

reaperrr commented Jun 29, 2017

Tested again with fetching latest bleed, bug is gone 👍
I can't help with the Linux/macOS scripts, but on the Windows side things look mergable (maybe update last commit to fetch latest bleed before merging).

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 29, 2017

Member

Done.

Member

pchote commented Jun 29, 2017

Done.

@pchote pchote merged commit 1b7f42a into master Jun 29, 2017

@abcdefg30 abcdefg30 deleted the engine-management branch Jun 29, 2017

@abcdefg30 abcdefg30 referenced this pull request Sep 1, 2018

Merged

Delete .gitmodules #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment