Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place path through object does not remove object on server #3852

Closed
1 of 2 tasks
YJSoft opened this issue Jun 10, 2016 · 6 comments
Closed
1 of 2 tasks

Place path through object does not remove object on server #3852

YJSoft opened this issue Jun 10, 2016 · 6 comments
Labels
bug Something went wrong. multiplayer Related to the multiplayer functionality of OpenRCT2.

Comments

@YJSoft
Copy link
Contributor

YJSoft commented Jun 10, 2016 •
edited

OS: OS X
Version: 0.0.5
Commit/Build: 504e5e0

Place path through object only removes object on client side, not server side.

  • Reproducible in RCT2 (vanilla)?
  • Multiplayer?

Screenshots / Video:

  1. Building path on server, watching on server(works fine)
    image
  2. Building path on server, watching on client(object not deleted - reconnect solves problem)
    image
  3. Building path on client without any permission, watching on client(although fence is removed, since client has no permission so there's no effect to server)
    image
  4. Building path on client with permission, watching on client(looks fine, but after reconnect object is still there)
    image
  5. Building path on client with permission, watching on server(result is same to 2.)
    image
@Gymnasiast Gymnasiast added bug Something went wrong. multiplayer Related to the multiplayer functionality of OpenRCT2. labels Jun 10, 2016
@janisozaur
Copy link
Member

I have tested it on recent version (around abad7dd or a few commits earlier) and it doesn't seem to happen any more.

I'd like some independent confirmation this is really gone before closing though.

One thing that stood out to me and perhaps hid this bug, is that I could not build a path with the arrow buttons, but only by placing each path element explicitly with mouse cursor.

@Broxzier
Copy link
Member

Broxzier commented Jan 17, 2017 •
edited

@janisozaur #5080 probably fixed this.

@janisozaur
Copy link
Member

I'm not sure if the version I tested already had that in, would be worth checking

@IntelOrca
Copy link
Contributor

@Broxzier the issue said nothing about disable clearance checks

@Margen67 Margen67 mentioned this issue May 9, 2017
Closed
@janisozaur
Copy link
Member

There's also a park reproducing the issue attached in #5459 (comment)

@rwjuk
Copy link
Contributor

rwjuk commented May 10, 2017

Interestingly, on macOS on the latest build I cannot replicate this. The client doesn't delete the fence and no desync occurs.

This was referenced Aug 6, 2017
Merged
Closed
ZehMatt added a commit to ZehMatt/OpenRCT2 that referenced this issue Aug 6, 2017
@ZehMatt
Fix OpenRCT2#3852: Desync constructing path with scenery in its way.
3a3359b
ZehMatt added a commit to ZehMatt/OpenRCT2 that referenced this issue Aug 6, 2017
@ZehMatt
Fix OpenRCT2#3852: Desync constructing path with scenery in its way.
7e9576e
janisozaur added a commit to janisozaur/OpenRCT2 that referenced this issue Aug 9, 2017
@janisozaur
Release 0.1.1
4333295 
- Feature: [OpenRCT2#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [OpenRCT2#5857] Keyboard shortcut for clear scenery.
- Feature: [OpenRCT2#5877] Allow up to 16 stations to be synchronised
- Feature: [OpenRCT2#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [OpenRCT2#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [OpenRCT2#2127, OpenRCT2#2229, OpenRCT2#5586] Mountain tool cost calculation
- Fix: [OpenRCT2#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [OpenRCT2#3852] Constructing path not clearing scenery on server.
- Fix: [OpenRCT2#4455] Crash in window_sign_invalidate due to original bug
- Fix: [OpenRCT2#4715] Fix OpenGL rendering of water when zoomed. See OpenRCT2#5890.
- Fix: [OpenRCT2#4931] Crash in path_paint - footpathentry was null
- Fix: [OpenRCT2#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [OpenRCT2#5768] Prevent loading non-existent title sequences.
- Fix: [OpenRCT2#5858] Crash when using custom ride with no colour presets.
- Fix: [OpenRCT2#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [OpenRCT2#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [OpenRCT2#5880] Leaving bumper cars without building causes assertion.
- Fix: [OpenRCT2#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [OpenRCT2#5912] Negative queue when moving entrance in paused state.
- Fix: [OpenRCT2#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [OpenRCT2#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [OpenRCT2#5977] Custom music files not showing up in music list
- Fix: [OpenRCT2#5981] Ride list doesn't update after using quick demolish.
- Fix: [OpenRCT2#5984] Allow socket binding to same port after crash
- Fix: [OpenRCT2#5998] Staff not getting paid / no loan interest.
- Fix: [OpenRCT2#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [OpenRCT2#6052] Unable to place entrance/exit on certain ride types.
- Fix: [OpenRCT2#6071] Quick demolish can delete protected ride.
- Fix: [OpenRCT2#6111] Mute button always visible in editor.
- Fix: [OpenRCT2#6113] Track preview shows incorrect highest drop height.
- Improved: [OpenRCT2#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [OpenRCT2#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [OpenRCT2#5859] OpenGL rendering performance
- Improved: [OpenRCT2#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [OpenRCT2#6003] Doors placed on tracks will now work with all vehicles
- Improved: [OpenRCT2#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
janisozaur added a commit that referenced this issue Aug 9, 2017
@janisozaur
Release 0.1.1
4601265 
- Feature: [#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [#5857] Keyboard shortcut for clear scenery.
- Feature: [#5877] Allow up to 16 stations to be synchronised
- Feature: [#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [#2127, #2229, #5586] Mountain tool cost calculation
- Fix: [#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [#3852] Constructing path not clearing scenery on server.
- Fix: [#4455] Crash in window_sign_invalidate due to original bug
- Fix: [#4715] Fix OpenGL rendering of water when zoomed. See #5890.
- Fix: [#4931] Crash in path_paint - footpathentry was null
- Fix: [#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [#5768] Prevent loading non-existent title sequences.
- Fix: [#5858] Crash when using custom ride with no colour presets.
- Fix: [#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [#5880] Leaving bumper cars without building causes assertion.
- Fix: [#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [#5912] Negative queue when moving entrance in paused state.
- Fix: [#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [#5977] Custom music files not showing up in music list
- Fix: [#5981] Ride list doesn't update after using quick demolish.
- Fix: [#5984] Allow socket binding to same port after crash
- Fix: [#5998] Staff not getting paid / no loan interest.
- Fix: [#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [#6052] Unable to place entrance/exit on certain ride types.
- Fix: [#6071] Quick demolish can delete protected ride.
- Fix: [#6111] Mute button always visible in editor.
- Fix: [#6113] Track preview shows incorrect highest drop height.
- Improved: [#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [#5859] OpenGL rendering performance
- Improved: [#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [#6003] Doors placed on tracks will now work with all vehicles
- Improved: [#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong. multiplayer Related to the multiplayer functionality of OpenRCT2.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@janisozaur @Gymnasiast @IntelOrca @YJSoft @Broxzier @rwjuk