Crash in window_sign_invalidate due to original bug

[remcooo96]

Mac OSX
0.0.5
426e106

• Reproducible in RCT2 (vanilla)? YES, tested

I have signs in my park that cannot be deleted. Al these "ghost signs" are connected, if I want to give one of them a new name, whatever sign I choose it always shows the same location in the little window (the place it shows doesn't even have a sign. When I change its name, all the names of the ghost signs adopt this name. In openrct even touching the signs lead to a crash, in vanilla just the above described happens.

I will add the dump file from macos and the savegame (some ghost signs are in the middle of the screen when you open it)

crash report.zip
Astoria10000.sv6.zip

[janisozaur]

0   website.openrct2.OpenRCT2       0x020bed83 window_sign_invalidate + 54
1   website.openrct2.OpenRCT2       0x0208f598 window_draw + 518
2   website.openrct2.OpenRCT2       0x020d677c window_draw_all + 215
3   website.openrct2.OpenRCT2       0x0207740e SoftwareDrawingEngine::DrawDirtyBlocks(unsigned int, unsigned int, unsigned int, unsigned int) + 224
4   website.openrct2.OpenRCT2       0x02076f2c SoftwareDrawingEngine::DrawAllDirtyBlocks() + 170
5   website.openrct2.OpenRCT2       0x02076845 SoftwareDrawingEngine::Draw() + 131
6   website.openrct2.OpenRCT2       0x0210079b drawing_engine_draw + 26
7   website.openrct2.OpenRCT2       0x02054faf openrct2_launch + 972
8   website.openrct2.OpenRCT2       0x0204a1fa main + 41
9   website.openrct2.OpenRCT2       0x020011f5 start + 53

Thread 0 crashed with X86 Thread State (32-bit):
  eax: 0x00000000  ebx: 0x00000000  ecx: 0x00000000  edx: 0x0229a03c
  edi: 0x022f4cdc  esi: 0x020bed5a  ebp: 0xbffffab8  esp: 0xbffffaa0
   ss: 0x00000023  efl: 0x00210246  eip: 0x020bed83   cs: 0x0000001b
   ds: 0x00000023   es: 0x00000023   fs: 0x00000000   gs: 0x0000000f
  cr2: 0x00000007

scenery_entry must be NULL:

OpenRCT2/src/windows/sign.c

Line 333 in f8145b6

rct_scenery_entry* scenery_entry = get_large_scenery_entry(w->var_48C);

[remcooo96]

Okay thats probably the problem, but can you explain what it means. Im no programming wonder, sorry ;)

[janisozaur]

It means we know what the problem is, bringing us one step closer to solution. Making it not crash would probably be simple, but fixing such signs properly (so that you can actually delete it or change its value) may require some more effort.

[duncanspumpkin]

How did you create the ghost signs. There was a bug in vanilla that causes them but I fixed that for open

[remcooo96]

I have honestly no idea, I just started noticing them when I tried to delete one, which caused the game to crash. I know the roots of my savegame are made in vanilla and were then build further in Openrct.

[duncanspumpkin]

The bug that caused them in vanilla was when building two signs with same direction on different paths that share x y coordinates but different heights.

[remcooo96]

I think I indeed had two signs at different levels. I hope it is fixable. At least stopping the game from crashing would be big improvement :)