Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build lacks full immersive mode without top navbar #6553

Closed
Invictaz opened this issue Oct 24, 2017 · 5 comments
Closed

Android build lacks full immersive mode without top navbar #6553

Invictaz opened this issue Oct 24, 2017 · 5 comments
Labels

Comments

@Invictaz
Copy link

@Invictaz Invictaz commented Oct 24, 2017

OS: Android 6.0.1
Version: 0.1.2

The top bar is still shown with batterlife etc. This part of the screen cannot be used for scrolling with the mouse pointer.

Screenshots / Video:
screenshot_20171025-001240

@Invictaz

This comment has been minimized.

Copy link
Author

@Invictaz Invictaz commented Feb 7, 2020

@AaronVanGeffen Please don't close issues that are NOT solved.

@Gymnasiast

This comment has been minimized.

Copy link
Member

@Gymnasiast Gymnasiast commented Feb 7, 2020

#10402 added fullscreen mode to Android.

@AaronVanGeffen

This comment has been minimized.

Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Feb 7, 2020

It was my intention to leave a note with the PR number, but got sidetracked. Sorry about that.

@Gymnasiast

This comment has been minimized.

Copy link
Member

@Gymnasiast Gymnasiast commented Feb 7, 2020

Well, it beats not having it run at all, which was the case until NuclearFej fixed it.

Now, can you please act a little less entitled? First, you assume the problem has not been fixed without checking if that was the case, then you place a rude comment to Aaron and when we point out that the bug has, in fact, been fixed, you're complaining that it doesn't work on your device. If you want support for Android 8, we're happy to accept your PRs.

@Invictaz

This comment has been minimized.

Copy link
Author

@Invictaz Invictaz commented Feb 7, 2020

I don't know what you want to read, but that was in no way a rude intended comment.
And he started to close an issue without referring to the fix. The fix is appreciated.

Gymnasiast added a commit that referenced this issue Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.