Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate functions #10067

Open
wants to merge 4 commits into
base: develop
from

Conversation

@tupaschoal
Copy link
Contributor

commented Oct 9, 2019

Just some small changes that extract equal code to functions or calls another one instead of doing exactly the same thing.

@janisozaur janisozaur self-requested a review Oct 9, 2019
tupaschoal added 4 commits Oct 9, 2019
`window_resize_gui_scenario_editor` was a subset of `window_resize_gui`
Both `GetFollowers()` and `GetMessage()` were very similar
`map_place_non_scenery_clear_func` and `map_place_scenery_clear_func` did basically the same thing, with a single branch difference
Make `top_toolbar_tool_update_scenery_clear` call `top_toolbar_tool_update_land_paint` and then do the additional differing calculation it did.
@tupaschoal tupaschoal force-pushed the tupaschoal:remove-duplicates branch from 614ae9c to 8bb275b Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.