Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 9113 refactor g vehicle sound params list #10070

Open
wants to merge 9 commits into
base: develop
from

Conversation

@UltimaBGD
Copy link

commented Oct 9, 2019

This is a refactor of the gVehicleSoundParams List as referenced in #9113.

I have renamed it to vehicleSoundParams and initialized it within the vehicle_sound_update, and pass it to vehicle_update_sound_params.

@Gymnasiast

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Did you actually manage to compile it yourself? All CIs are red.

@UltimaBGD

This comment has been minimized.

Copy link
Author

commented Oct 10, 2019

My apologies, it seems I am having some issues on my end with Visual Studio. I will get back on this very shortly.

UltimaBGD added 4 commits Oct 10, 2019
@Gymnasiast Gymnasiast requested a review from duncanspumpkin Oct 10, 2019
UltimaBGD added 3 commits Oct 18, 2019
@UltimaBGD

This comment has been minimized.

Copy link
Author

commented Oct 19, 2019

The only changes were to that one file, so I am unsure why Travis is erroring on certain builds now.

@duncanspumpkin

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2019

Hmm this certainly works but I'm thinking std::array is horrible for this. std::vector isn't great either due to the memory allocations.

@UltimaBGD

This comment has been minimized.

Copy link
Author

commented Oct 19, 2019

std::array was specified in the initial issue, so that is why I ended up using it.

@duncanspumpkin

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2019

Yeah i know. Just having a think of anyway to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.