Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifdef-out WinNT 6.0+ APIs #10198

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@janisozaur
Copy link
Member

janisozaur commented Nov 6, 2019

Occasionally I need to build a binary compatible with WinNT 5.1, e.g.
when testing out Wine or ReactOS. There are just a few minor changes
required to have a working build, but as they are not part of the
repository, I always end up doing them from scratch. I would like to
upstream them instead so I don't have to recreate them each time, even
if this is not the most common use case.

Occasionally I need to build a binary compatible with WinNT 5.1, e.g.
when testing out Wine or ReactOS. There are just a few minor changes
required to have a working build, but as they are not part of the
repository, I always end up doing them from scratch. I would like to
upstream them instead so I don't have to recreate them each time, even
if this is not the most common use case.
Copy link
Contributor

tupaschoal left a comment

I'm thinking about experimenting with something like these structures to improve how platform specific things are chosen

src/openrct2-ui/UiContext.Win32.cpp Show resolved Hide resolved
src/openrct2/core/String.cpp Show resolved Hide resolved
@janisozaur

This comment has been minimized.

Copy link
Member Author

janisozaur commented Nov 8, 2019

@tupaschoal until such feature gets implemented, I'm going to merge this as-is to address the current needs.

@janisozaur janisozaur merged commit afc92ee into OpenRCT2:develop Nov 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janisozaur janisozaur deleted the janisozaur:winnt5.1 branch Nov 8, 2019
@tupaschoal

This comment has been minimized.

Copy link
Contributor

tupaschoal commented Nov 9, 2019

Sure, I didn't mean for you to wait, just speaking out loud on things I could do in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.