Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8585: Part of track missing on air powered vertical coaster (#8635) #10205

Open
wants to merge 2 commits into
base: develop
from

Conversation

@janisozaur
Copy link
Member

janisozaur commented Nov 8, 2019

@deurklink as original reporter of #8585, can you please check?

This work addresses a possible regression found by testpaint and tracked in #10204

janisozaur added 2 commits Nov 8, 2019
…cal coaster (#8635)

In #10204 it was found that
the issue the reverted commit tried to fix was likely a regression from
#8550
@janisozaur janisozaur requested a review from Gymnasiast Nov 8, 2019
@Gymnasiast

This comment has been minimized.

Copy link
Member

Gymnasiast commented Nov 9, 2019

I might be missing some background, but why this change? The resulting code is messier, IMO.

If it is to address TestPaint failing: it wouldn't be the first time TestPaint is failing while the drawing is correct. That has happened in #6526 , for example.

@janisozaur

This comment has been minimized.

Copy link
Member Author

janisozaur commented Nov 9, 2019

If you vouch for the fix that's already present in the repo, feel free to close this PR. I made it as I noticed one of my commits caused an increase in testpaint's failing tests

@Gymnasiast

This comment has been minimized.

Copy link
Member

Gymnasiast commented Nov 10, 2019

I can vouch that my fix fixed #8585. I don't know if my fix also satisfied TestPaint, but the drawing is correct, at least.

If my fix fails TestPaint and your PR does not, I don't mind this going in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.