Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use CoordsXY objects in world/Footpath.cpp #10559

Merged
merged 5 commits into from Jan 14, 2020

Conversation

@tupaschoal
Copy link
Contributor

tupaschoal commented Jan 13, 2020

I double check and it seems like this patch eliminates all the remaining {x, y} usages on footpath.

@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-5 branch from b2dfede to 84cd322 Jan 13, 2020
@tupaschoal

This comment has been minimized.

Copy link
Contributor Author

tupaschoal commented Jan 13, 2020

Fixed pending issues.

Copy link
Contributor

duncanspumpkin left a comment

All looks fine. At some point it would be good to use the direction Delta on those wide flags as i think it would read better and be easier to turn into a for loop.

src/openrct2/world/Footpath.cpp Show resolved Hide resolved
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-5 branch from 84cd322 to 931adaa Jan 14, 2020
@Gymnasiast Gymnasiast merged commit b9ee231 into OpenRCT2:develop Jan 14, 2020
5 checks passed
5 checks passed
Check code formatting
Details
macOS
Details
Linux (x64, AppImage)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tupaschoal tupaschoal deleted the tupaschoal:use-more-coords-5 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.