Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer CoordsXY* on more places #10570

Merged
merged 9 commits into from Jan 19, 2020
Merged

Conversation

@tupaschoal
Copy link
Contributor

tupaschoal commented Jan 14, 2020

No description provided.

@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from 036c492 to 4f3943f Jan 14, 2020
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from 4f3943f to 6c3ee77 Jan 15, 2020
Copy link
Member

Gymnasiast left a comment

The TestPaint counterpart of CoordsDirectionDelta needs to be modified too.

@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from 6c3ee77 to f9836f9 Jan 16, 2020
@tupaschoal

This comment has been minimized.

Copy link
Contributor Author

tupaschoal commented Jan 16, 2020

Done

test/testpaint/Compat.cpp Outdated Show resolved Hide resolved
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from f9836f9 to 28fa784 Jan 17, 2020
test/testpaint/Compat.cpp Outdated Show resolved Hide resolved
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from 28fa784 to b8c961c Jan 17, 2020
src/openrct2/world/Map.cpp Outdated Show resolved Hide resolved
test/testpaint/Compat.cpp Outdated Show resolved Hide resolved
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from b8c961c to eec2298 Jan 18, 2020
Copy link
Contributor

duncanspumpkin left a comment

See comments

Copy link
Member

Gymnasiast left a comment

All my requests are now implemented.

Can be merged once Duncan's requests are implemented as well.

@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from eec2298 to 7bc6fcc Jan 19, 2020
@tupaschoal tupaschoal force-pushed the tupaschoal:use-more-coords-6 branch from 7bc6fcc to b7e9b36 Jan 19, 2020
@tupaschoal

This comment has been minimized.

Copy link
Contributor Author

tupaschoal commented Jan 19, 2020

We only need to converge on the open issues now

@Gymnasiast Gymnasiast merged commit b1e8caa into OpenRCT2:develop Jan 19, 2020
6 checks passed
6 checks passed
Check code formatting
Details
Windows (win32)
Details
Windows (x64)
Details
macOS
Details
Linux (x64, AppImage)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tupaschoal tupaschoal deleted the tupaschoal:use-more-coords-6 branch Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.