Fix #5684: Refactor player list updates being bound on ticks. #8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You meant this was possible previously, and your PR solved this? |
janisozaur
approved these changes
Dec 9, 2018
|
Oh, forgot to mention: should have been in the changelog. |
|
Yes before the PR it would have crashed. And sorry about the changelog, was kinda hoping someone will point it out before merge, never sure when to put something in it. |
|
Almost everything can go in, as long as it has been in the game since the last release (or earlier). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue has been open for too long, this was fairly easy to do. Now the player list should be identical on server and clients at all time. Currently its possible to crash the clients if the client issues a game command and quickly disconnects/gets kicked at nearly the same time.