Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor network groups out of network #9921
Some things I should mention what this PR does:
Also the "Admin" group is currently immutable which I assume has been only the case because the host was enforced to use the admin group, now that this is no longer the case should we allow users to modify the admin group?
Yes. I think starting off with a few default groups like "Admin", "User, and "Spectator" are good, but give full control about them to the user.
duncanspumpkin left a comment
This looks fine. We had a discussion about using a std::vector for the _groups on gitter but its fine to do it this way as well.
Its not the greatest to use unique ptr .get() but at least every instance of this doesn't take any ownership.
I've modified the way it loads and saves the configuration to use names which is much easier for the initial setup and doesn't require to back track files.
The new format for groups.json:
The new format for users.json:
As for the new rules:
Old configuration should not need to be changed as it will still use the id for a one way import to the new format.
I've bumped up the network version and added a changelog entry, from my end its good to go but it would be nice if someone could do a few tests.