Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DomainClient contract to Task based async methods #153

Merged
merged 18 commits into from Jul 7, 2019
Merged

Change DomainClient contract to Task based async methods #153

merged 18 commits into from Jul 7, 2019

Conversation

Daniel-Svensson
Copy link
Member

@Daniel-Svensson Daniel-Svensson commented Jun 16, 2019 •
edited

Change DomainClient contract from APM pattern to using Task based async methods to make extensibility easier.

  • Try different approaches for service call to se how it affect memory usage
    • Look into passing more state using extra object parameters (ContinueWith, BeginXXX ... )
  • Look into AuthenticationService to see if AsyncBase can be removed
    • there is much work to do there before removal. It is out of scope for this pr

@Daniel-Svensson Daniel-Svensson marked this pull request as ready for review July 4, 2019 14:33
Daniel-Svensson
Daniel-Svensson commented Jul 4, 2019
View reviewed changes
OpenRiaServices.DomainServices.Client/Framework/PortabilityExtensions.cs Outdated
@@ -11,5 +12,32 @@ public static ReadOnlyCollection<T> AsReadOnly<T>(this List<T> list)
{
return new ReadOnlyCollection<T>(list);
}

#if SILVERLIGHT
public struct TaskAwaiter<T>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change namespace and move to separate file

OpenRiaServices.DomainServices.Client/Test/Desktop/Data/WebDomainClientTests.cs Outdated Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Test/Desktop/Data/WebDomainClientTests.cs Outdated Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Test/Desktop/Data/WebDomainClientTests.cs Outdated Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Test/Desktop/Data/DomainClientTests.cs Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Test/Desktop/Data/DomainClientTests.cs Outdated Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Framework/Data/DomainContext.cs Outdated Show resolved Hide resolved
OpenRiaServices.DomainServices.Client/Framework/Data/DomainContext.cs Show resolved Hide resolved
@Daniel-Svensson Daniel-Svensson self-assigned this Jul 4, 2019
@Daniel-Svensson Daniel-Svensson merged commit 34adb69 into OpenRIAServices:master Jul 7, 2019
@Daniel-Svensson Daniel-Svensson deleted the feature/async_domainclient branch July 7, 2019 18:49
@Daniel-Svensson Daniel-Svensson added this to the 5.0 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Daniel-Svensson Daniel-Svensson

Labels
Area-Client Breaking Change performance Platform-All
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Daniel-Svensson