feat: Remove dependency on original executable for circles palette data#28
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the HnmPlayer runtime dependency on locating/reading the original LOGO.EXE in order to prime the circles palette animation state, by embedding the required palette state bytes directly in the player.
Changes:
- Adds
CirclesPaletteData.csto hold embedded circles palette initialization data. - Updates
HnmPlaybackEngine.InitializeCirclesPaletteAnimationState()to copy from embedded data and removes theFindOriginalExecutablePath(...)lookup/read path. - Updates
HnmPlayer.csprojto compile the new source file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| HnmPlayer/HnmPlayer.csproj | Adds the new embedded-data source file to the explicit compile list. |
| HnmPlayer/HnmPlaybackEngine.cs | Switches circles palette init from reading LOGO.EXE to using embedded data; removes exe discovery helper. |
| HnmPlayer/CirclesPaletteData.cs | Introduces embedded circles palette table/step width (and a placeholder buffer) for standalone playback. |
Comment on lines
+6
to
+8
| public const ushort StepWidth = 1; | ||
| public static readonly byte[] Buffer = new byte[0xF0]; | ||
| public static readonly byte[] Table = Convert.FromHexString( |
Comment on lines
+6
to
+9
| public const ushort StepWidth = 1; | ||
| public static readonly byte[] Buffer = new byte[0xF0]; | ||
| public static readonly byte[] Table = Convert.FromHexString( | ||
| "28000001340089001F0000FF800091002D000001C50022003900C0FF00FF00002C0024FF000000FF5000000000000000" + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.