Allow facet-undo/redo panel to be shown/hidden #1038
Assignees
Labels
Difficulty: Intermediate
Identifies moderately challenging issues that require some experience and familiarity with project.
Module: Frontend
These issues involve working on HTML, CSS, and JavaScript code that affects the user interface.
Type: Feature Request
Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone
Comments
tfmorris
added
Type: Feature Request
tfmorris
changed the title
|
Rather than double clicking, the typical UI affordance for this kind of thing is a small arrow/triangle icon on the vertical splitter. |
|
related to (duplicate of ?) #1012 |
|
Not a duplicate, I think, but definitely related. This is a relatively simple request, as compared to the other. |
wetneb
added
Difficulty: Intermediate
|
Marking this as a bit more involved than a first issue since the way the layout is currently set up does not make it very easy to resize panels (panel sizes are computed explicitly in Javascript). Still an issue that should be totally doable though! |
@wetneb: can you explain to me in what this issue is different from what I implemented? Is this issue about hidding the whole left panel like in this video? Regards, Antoine |
|
Yes your video describes it pretty well! |
Then, I believe you will find that this PR does what shown in the video. Regards, |
antoine2711
changed the title
wetneb
added a commit
that referenced
this issue
May 30, 2020
* Add a Show/Hide left panel Add a Show/Hide left Facets-Undo/Redo panel. * Update summary-bar.js Simplify the code for the "hide-left-panel-button". * Remove the gap on the left of the button Remove the gap on the left of the button and align left with table. * Translated using Weblate (Japanese) Currently translated at 100.0% (740 of 740 strings) Translation: OpenRefine/Translations Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (171 of 171 strings) Translation: OpenRefine/wikidata Translate-URL: https://hosted.weblate.org/projects/openrefine/wikidata/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (47 of 47 strings) Translation: OpenRefine/gdata Translate-URL: https://hosted.weblate.org/projects/openrefine/gdata/ja/ * Updated showhide (collapse) arrow image * Bolden the border dark-blue Bolden the border dark-blue * Changed from SPAN to A tag Changed from SPAN to A tag. * Update project.less Minor change: left: 22px; * Add a Show/Hide left panel Add a Show/Hide left Facets-Undo/Redo panel. * Update summary-bar.js Simplify the code for the "hide-left-panel-button". * Remove the gap on the left of the button Remove the gap on the left of the button and align left with table. * Updated showhide (collapse) arrow image * Bolden the border dark-blue Bolden the border dark-blue * Changed from SPAN to A tag Changed from SPAN to A tag. * Update project.less Minor change: left: 22px; * Changed cell.error to cell.errorMessage & added help data. (#2628) * Changed cell.error to cell.errorMessage & added help data. Changed cell.error to cell.errorMessage and added the informations into the internal help system. * FR Text correction * HU Fix text 3 instead of 2. * The show/hide button now changes side The show/hide button now changes side. * Update project.js Removed unneeded self. * Update summary-bar.js Removed unneeded self. * [Security] Bump jackson.version from 2.9.10 to 2.11.0 Bumps `jackson.version` from 2.9.10 to 2.11.0. Updates `jackson-databind` from 2.9.10 to 2.11.0 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-annotations` from 2.9.10 to 2.11.0 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-core` from 2.9.10 to 2.11.0 - [Release notes](https://github.com/FasterXML/jackson-core/releases) - [Commits](FasterXML/jackson-core@jackson-core-2.9.10...jackson-core-2.11.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Translated using Weblate (Russian) Currently translated at 91.0% (674 of 740 strings) Translation: OpenRefine/Translations Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ru/ * Only show the database login fields when necessary (#2615) * DB login fields visibility controled by CSS The database login field’s visibility is now controled by CSS styling. * Change field name from Database to Database file. Change field name from Database to Database file. * Use full db name as CSS classes Use full db name instead of diminutives for the CSS classes. * Added translation to placeholders Added translation to the Input placeholders. * Undo a change, remerge Database field & File remerge Database field and DatabaseFile Field like before. * Created DatabaseSourceUI._updateDatabaseType(dbType) Created Refine.DatabaseSourceUI.prototype._updateDatabaseType(databaseType) * Make MySQL the default database <option value="mysql" selected="selected"">MySQL</option> * Update database-import-form.html Fixed typo. (<option value="mysql" selected="selected">MySQL</option>) * New default connection name value New default connection name value, translation of it, changing cssClassName from options to dbtype-options, adding the prefix "dbt-" to the db types and fix the changing of placeholder databaseName/databaseFileName when neccessary. * Fix issue with « saved connections » Fix issue with « saved connections » and added 2 defaults values for dbHost and dbType. * Default DB back to MySQL. <option value="mysql" selected="selected">MySQL</option> * Update extensions/database/module/langs/translation-en.json Co-authored-by: Thad Guidry <thadguidry@gmail.com> * Better default with « mysql » * Fix sqlite #databaseHost before calling self._updateDatabaseType() Fix $( "#databaseHost" ).val(self._defaultDatabaseHost) to be set before calling self._updateDatabaseType(self._defaultDatabaseType) that may change it. * Removed field name & fixed default connection name Removed field name text since it's populated from i18n and fixed the default connection name so that it has no space in it. * Little update to placeholder text Co-authored-by: Thad Guidry <thadguidry@gmail.com> * Resize the grid UI as well Co-authored-by: Isao Matsunami <isao.matsunami@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Thad Guidry <thadguidry@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tom Morris <tfmorris@gmail.com> Co-authored-by: Artem <KovalevArtem.ru@gmail.com> Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
antoine2711
added a commit
that referenced
this issue
Jun 8, 2020
antoine2711
added a commit
to antoine2711/OpenRefine
that referenced
this issue
Jun 17, 2020
…fine#2684) Fix a bug introduced by I OpenRefine#1038, where the first tab, in the Wikidata mode, would have a bad background. PR OpenRefine#2616
wetneb
pushed a commit
that referenced
this issue
Jun 17, 2020
* Start for Goto Page link.
First implementation. Is functional.
* Background-color & validation
Background-color for each « button » & validation for the page choice of the user: number, > 1 & < last & singular for a one page project.
* Changed from prompt() to <input type="number">
Changed from prompt() to <input type="number">, and visual X out Y.
* Manage bounds in a sticky way
If the user choose below 1, 1 will be displayed, and if the user choose above the max, the max page will be displayed.
* width of <input> & « of X pages »
Add pages after « of maxValue », calculate the width of <input> based on max value.
* Update data-table-view.js
Little fix.
* Correct min and max for <input>
Correct min and max for <input>
* Managment of the arrow's key down.
Add managment to keep the arrow's key in the CurrentPage <input>.
* Fixes for Thad’s KeyDown's « Infinite Paging »
Fixes for Thad’s KeyDown's « Infinite Paging » & PageSize changes.
* Code rehookCurrentPageInput & spacing
Code rehookCurrentPageInput & spacing for PageSize section
* Update data-table-view.js
Fix & move code in Page Control.
* Wrap in a Try/Catch the currentPageInput.focus()
Wrap in a Try/Catch the currentPageInput.focus() and add a verification of focus change with if(!(currentPageInput.is(":focus"))) window.setTimeout(rehookCurrentPageInput, rehookDelay).
* Fixed currentPageInput != document.activeElement
Fixed currentPageInput != document.activeElement
that was before: !(currentPageInput.is(":focus"))
* Better handling of the « Infinite Paging »
Better handling of the « Infinite Paging » with window.setTimeout(rehookCurrentPageInput, rehookDelay)
* $.i18n('core-views/goto-page', …
$.i18n('core-views/goto-page', '<span id="currentPageInput" />', '<span id="lastPageSpan" />'))
* Fix i18n plural
Fix i18n plural, FR still not fixed.
* Remove {{plural:$2|page|pages}} in french
Remove {{plural:$2|page|pages}} in French, not working.
* Update data-table-view.js
Forgot a semi-comma.
* First implementation
First implementation, is functional.
* Remove setTimeout(refocusCurrentPageInput, refocusDelay);
Remove setTimeout(refocusCurrentPageInput, refocusDelay);, instead, onready after creating the page input field.
* Typo: missing semi-colon
Typo: missing semi-colon
* Fix bug related to stealing focus of facets & added a delay
Fix bug related to stealing focus of facets & added a delay (1 s.) before changing pages.
* Revert "Remove {{plural:$2|page|pages}} in french"
This reverts commit 7274a21.
* Start for Goto Page link.
First implementation. Is functional.
* Background-color & validation
Background-color for each « button » & validation for the page choice of the user: number, > 1 & < last & singular for a one page project.
* Changed from prompt() to <input type="number">
Changed from prompt() to <input type="number">, and visual X out Y.
* Manage bounds in a sticky way
If the user choose below 1, 1 will be displayed, and if the user choose above the max, the max page will be displayed.
* width of <input> & « of X pages »
Add pages after « of maxValue », calculate the width of <input> based on max value.
* Update data-table-view.js
Little fix.
* Correct min and max for <input>
Correct min and max for <input>
* Managment of the arrow's key down.
Add managment to keep the arrow's key in the CurrentPage <input>.
* Fixes for Thad’s KeyDown's « Infinite Paging »
Fixes for Thad’s KeyDown's « Infinite Paging » & PageSize changes.
* Code rehookCurrentPageInput & spacing
Code rehookCurrentPageInput & spacing for PageSize section
* Update data-table-view.js
Fix & move code in Page Control.
* Wrap in a Try/Catch the currentPageInput.focus()
Wrap in a Try/Catch the currentPageInput.focus() and add a verification of focus change with if(!(currentPageInput.is(":focus"))) window.setTimeout(rehookCurrentPageInput, rehookDelay).
* Fixed currentPageInput != document.activeElement
Fixed currentPageInput != document.activeElement
that was before: !(currentPageInput.is(":focus"))
* Better handling of the « Infinite Paging »
Better handling of the « Infinite Paging » with window.setTimeout(rehookCurrentPageInput, rehookDelay)
* $.i18n('core-views/goto-page', …
$.i18n('core-views/goto-page', '<span id="currentPageInput" />', '<span id="lastPageSpan" />'))
* Bump rhino from 1.7.10 to 1.7.12
Bumps [rhino](https://github.com/mozilla/rhino) from 1.7.10 to 1.7.12.
- [Release notes](https://github.com/mozilla/rhino/releases)
- [Changelog](https://github.com/mozilla/rhino/blob/master/RELEASE-NOTES.md)
- [Commits](https://github.com/mozilla/rhino/commits)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Fix i18n plural
Fix i18n plural, FR still not fixed.
* Remove {{plural:$2|page|pages}} in french
Remove {{plural:$2|page|pages}} in French, not working.
* Update data-table-view.js
Forgot a semi-comma.
* Bump guava from 19.0 to 23.0
Bumps [guava](https://github.com/google/guava) from 19.0 to 23.0.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](google/guava@v19.0...v23.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump testng from 6.9.10 to 7.1.0
Bumps [testng](https://github.com/cbeust/testng) from 6.9.10 to 7.1.0.
- [Release notes](https://github.com/cbeust/testng/releases)
- [Changelog](https://github.com/cbeust/testng/blob/master/CHANGES.txt)
- [Commits](https://github.com/cbeust/testng/commits)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump to Guava 23.6.1-jre
* Bump jasypt from 1.9.2 to 1.9.3
Bumps [jasypt](https://github.com/jasypt/jasypt) from 1.9.2 to 1.9.3.
- [Release notes](https://github.com/jasypt/jasypt/releases)
- [Commits](https://github.com/jasypt/jasypt/commits/jasypt-1.9.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Added conflicts-with constraints (#2641)
Implemented conflicts-with scrutinizer as part of #2354
* Fix a bug introduced by I #1038, PR #2616 (#2684)
Fix a bug introduced by I #1038, where the first tab, in the Wikidata mode, would have a bad background. PR #2616
* Fixed typos made in PR #2641
* Remove setTimeout(refocusCurrentPageInput, refocusDelay);
Remove setTimeout(refocusCurrentPageInput, refocusDelay);, instead, onready after creating the page input field.
* Trim input url whitespace (#2534)
Fixes #2516
* Bump google-http-client-jackson2 from 1.20.0 to 1.35.0
Bumps [google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) from 1.20.0 to 1.35.0.
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/master/CHANGELOG.md)
- [Commits](googleapis/google-http-java-client@1.20.0...v1.35.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Switch to new rhino-runtime component
* Typo: missing semi-colon
Typo: missing semi-colon
* Replace Apache Ant with Commons Compress (#2691)
NOTE: Changes the public API where some of the old types were
embedded which means that any extensions that extend these
interfaces will have to be updated.
Fixes #2690.
* Fix bug related to stealing focus of facets & added a delay
Fix bug related to stealing focus of facets & added a delay (1 s.) before changing pages.
* Revert "Remove {{plural:$2|page|pages}} in french"
This reverts commit 7274a21.
* Update to latest Jython version 2.7.2
Closes #2642
* Bump git-commit-id-plugin from 2.2.4 to 4.0.0
Bumps [git-commit-id-plugin](https://github.com/git-commit-id/maven-git-commit-id-plugin) from 2.2.4 to 4.0.0.
- [Release notes](https://github.com/git-commit-id/maven-git-commit-id-plugin/releases)
- [Commits](git-commit-id/git-commit-id-maven-plugin@v2.2.4...v4.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump maven-assembly-plugin from 3.1.0 to 3.3.0
Bumps [maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from 3.1.0 to 3.3.0.
- [Release notes](https://github.com/apache/maven-assembly-plugin/releases)
- [Commits](apache/maven-assembly-plugin@maven-assembly-plugin-3.1.0...maven-assembly-plugin-3.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump httpclient from 4.5.5 to 4.5.12
Bumps httpclient from 4.5.5 to 4.5.12.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump powermock.version from 2.0.2 to 2.0.7
Bumps `powermock.version` from 2.0.2 to 2.0.7.
Updates `powermock-module-testng` from 2.0.2 to 2.0.7
- [Release notes](https://github.com/powermock/powermock/releases)
- [Changelog](https://github.com/powermock/powermock/blob/release/2.x/docs/changelog.txt)
- [Commits](powermock/powermock@powermock-2.0.2...powermock-2.0.7)
Updates `powermock-api-mockito2` from 2.0.2 to 2.0.7
- [Release notes](https://github.com/powermock/powermock/releases)
- [Changelog](https://github.com/powermock/powermock/blob/release/2.x/docs/changelog.txt)
- [Commits](powermock/powermock@powermock-2.0.2...powermock-2.0.7)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump butterfly from 1.0.2 to 1.0.3
Bumps [butterfly](https://github.com/OpenRefine/simile-butterfly) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/OpenRefine/simile-butterfly/releases)
- [Commits](https://github.com/OpenRefine/simile-butterfly/commits)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump slf4j-api from 1.7.18 to 1.7.30
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.18 to 1.7.30.
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.18...v_1.7.30)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Bump commons-validator from 1.5.1 to 1.6
Bumps commons-validator from 1.5.1 to 1.6.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Added translation using Weblate (Portuguese (Brazil))
* Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (47 of 47 strings)
Translation: OpenRefine/gdata
Translate-URL: https://hosted.weblate.org/projects/openrefine/gdata/pt_BR/
* Translated using Weblate (Japanese)
Currently translated at 100.0% (179 of 179 strings)
Translation: OpenRefine/wikidata
Translate-URL: https://hosted.weblate.org/projects/openrefine/wikidata/ja/
* Disables FacetContainer while computing clusters
fixes #2675
* Added translation using Weblate (Portuguese (Brazil))
* Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (740 of 740 strings)
Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/pt_BR/
* Added translation using Weblate (Portuguese (Brazil))
* Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (60 of 60 strings)
Translation: OpenRefine/database
Translate-URL: https://hosted.weblate.org/projects/openrefine/database/pt_BR/
* Translated using Weblate (Portuguese (Brazil))
Currently translated at 6.7% (12 of 179 strings)
Translation: OpenRefine/wikidata
Translate-URL: https://hosted.weblate.org/projects/openrefine/wikidata/pt_BR/
* Translated using Weblate (Japanese)
Currently translated at 100.0% (60 of 60 strings)
Translation: OpenRefine/database
Translate-URL: https://hosted.weblate.org/projects/openrefine/database/ja/
* Translated using Weblate (Japanese)
Currently translated at 100.0% (740 of 740 strings)
Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
* Translated using Weblate (Japanese)
Currently translated at 100.0% (60 of 60 strings)
Translation: OpenRefine/database
Translate-URL: https://hosted.weblate.org/projects/openrefine/database/ja/
* Added translation using Weblate (Bengali (India))
* Load GDrive icon from local resource, not Github (#2689)
Fixes #2688.
* Convert illegal characters into legal ones. (#2431)
* Convert illegal characters into leagal ones.
* Test tab in key & value string
Also fix up test that depended on previous TAB
related error message and clean up logging
Co-authored-by: Tom Morris <tfmorris@gmail.com>
* Bump signpost-commonshttp4 from 1.2.1.2 to 2.0.0 (#2695)
Bumps [signpost-commonshttp4](https://github.com/mttkay/signpost) from 1.2.1.2 to 2.0.0.
- [Release notes](https://github.com/mttkay/signpost/releases)
- [Changelog](https://github.com/mttkay/signpost/blob/master/CHANGELOG.md)
- [Commits](mttkay/signpost@1.2.1.2...oauth-signpost-2.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Add comment to help designers understand TreeData (#2715)
* Update jquery.i18n to 1.07 and fix non-English plural support (#2717)
* Update jquery.i18n to 1.07 and add missing rule parser
Fixes #2700
Adds missing CLDRPluralRuleParser.js so that plurals are supported.
Updates all files to jquery.i18n 1.07
Includes a bunch of specialty language support,
but only Finnish and Russian are loaded as examples.
* Add some missing translations, including plurals
Fix some cases of Javascript string concatenation and
plural conditionalization to demonstrate that plurals work
in both English and French now.
NOTE: Corresponding updates need to be made to all the other
language files since some keys were renamed or eliminated.
* Unused imports and other minor cleanups (#2723)
* Two minor fixes
- prevent invalid index error on empty strings (shouldn't normally happen)
- update deprecated Apache Commons Lang method
* Remove unused imports
* Remove feature Edit Facet Name
Remove feature Edit Facet Name that got merged by mistake.
* Remove feature Edit Facet Name
Remove feature Edit Facet Name that got merged by mistake.
* Spacing
Spacing
* Fix the delay, adjust to .2 s.
Fix the delay, adjust to .2 s. and stop using promises.
* Fix headerTable to tableHeader
Fix headerTable to tableHeader (PR #2719)
* data-header-table to data-table-header
data-header-table to data-table-header
* Remove .data-header-table-container
Remove .data-header-table-container
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Tom Morris <tfmorris@gmail.com>
Co-authored-by: Ekta Mishra <ektamishra1999@gmail.com>
Co-authored-by: Nishtha <51858166+Nishtha3512@users.noreply.github.com>
Co-authored-by: Thad Guidry <thadguidry@gmail.com>
Co-authored-by: Rafael Fontenelle <rafaelff@gnome.org>
Co-authored-by: Isao Matsunami <isao.matsunami@gmail.com>
Co-authored-by: Biswaranjan Manna <manna.biswaranjan@gmail.com>
Co-authored-by: chuhao zeng <32441682+zengchu2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice to be able to minimize the left panels(that show the facets). This give more space to maneuver without having to use the scroll up and down. I know we can resize the panels but doubleclicking the title area and having it toggle to regular size or minimize would be nice.
The text was updated successfully, but these errors were encountered: