Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frustrating UI for the selection of reconciliation services. #1658

Closed
wetneb opened this issue Jun 19, 2018 · 13 comments
Closed

Frustrating UI for the selection of reconciliation services. #1658

wetneb opened this issue Jun 19, 2018 · 13 comments
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features
Milestone

Comments

@wetneb
Copy link
Member

wetneb commented Jun 19, 2018

Steps followed to create the issue:

Select a reconciliation service - the service panel sometimes comes back
https://twitter.com/ruthbrarian/status/1008786606495584257
The UI should be more intuitive there.

Version of OpenRefine used:

3.0

@wetneb wetneb added Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features labels Jun 19, 2018
@tfmorris
Copy link
Member

That tweet no longer exists. Is there any more information available on when this happens (a particular reconciliation service?) or why?

@thadguidry
Copy link
Member

thadguidry commented Jun 17, 2020

@tfmorris I sent her an email just now:

Hi Ruth,

We are curious if you still have problems with the Reconciliation Service panel in OpenRefine.We saw that you opened the issue here:#1658 and would like for you to give us a bit more information if you recall if it was Wikidata Recon service or some other custom Recon service that caused the panel to "come back".

Please add the steps into the issue if you recall them (2 years ago!) and we can take a look more deeply. If the issue has been resolved, then just type in an issue comment that you no longer have this problem or that you are using a newer OpenRefine version that has fixed the issue for you.

Thanks so much!

@wetneb
Copy link
Member Author

wetneb commented Jun 17, 2020

There you go:
recon_dialog_ui_bug

@ruthtillman
Copy link

Checking my twitter archive, I found the tweet was "This box will. not. stay. shut. It's like an over-sugared toddler. Any tips? #openrefine ??????????????????? Whyyyy. (I click either services or the bookmark-type icon and it closes and then hey it's back again)"

the above demonstrates it. And I think in the interim I've switched versions and that might've solved it? But maybe not. However if you can still do the above... yeah, that's it. :-/

@thadguidry
Copy link
Member

thadguidry commented Jun 17, 2020

@wetneb Is that still a problem in 3.4 version?
@ruthtillman Thanks so much for the info!

@wetneb
Copy link
Member Author

wetneb commented Jun 17, 2020

Yes it is still current.

@tfmorris
Copy link
Member

A related issue, which might actually be triggering this, is that the panel doesn't close after adding a new service, obscuring the rest of the panel. I didn't recognize the little tab as a "close" affordance, so ended up dismissing the entire dialog and then starting the reconciliation over again.

@thadguidry
Copy link
Member

thadguidry commented Jul 10, 2020

I think we should simplify this. So opened a new issue for that in #2916

@wetneb
Copy link
Member Author

wetneb commented Aug 13, 2020

@pyrog is the problem still present on the master branch? This issue should have been closed by #2915. (It has not been closed because it was not properly linked to the pull request)

@pyrog
Copy link

pyrog commented Aug 13, 2020

@pyrog is the problem still present on the master branch?

Yes with Firefox 😞
Also, there is the same issue when you delete a service.

But it worked fine with Chrome 😃
Version 84.0.4147.125 (Build officiel) (64 bits)

And with Safari, issue #2990 is still there 😢

@allanaaa
Copy link
Contributor

allanaaa commented Sep 9, 2020

This problem persists in Firefox with 3.4 - I've never seen it before today, when I added the GND service. I wonder if it's happening (at this state) because certain services don't go into "Working" and thus trigger a retraction.

service-tab

It both stays shut when you want it open, and stays open when you want it shut.

service-tab2

@wetneb
Copy link
Member Author

wetneb commented Sep 10, 2020

Yes we have not released this in 3.4, it will only be there in 3.5.

@wetneb
Copy link
Member Author

wetneb commented Mar 24, 2021

This was closed by #2915, it is a duplicate of #2913.

@wetneb wetneb closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features
Projects
None yet
Development

No branches or pull requests

6 participants