Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu for joining columns #2109

Closed
msaby opened this issue Aug 3, 2019 · 4 comments
Closed

Add menu for joining columns #2109

msaby opened this issue Aug 3, 2019 · 4 comments

Comments

@msaby
Copy link
Member

@msaby msaby commented Aug 3, 2019

Is your feature request related to a problem or area of OpenRefine? Please describe.
The user should have the ability to join columns from a menu, without writing code. Using join() is tedious when you have a lot of columns to join. It would be the complementary operation of "Edit column > Split into several columns" menu

Describe the solution you'd like
I will submit soon a PR : I wrote a wrapper around "join ()" function, with some options :

  • chosing the columns to merge (menu inspired by "Custom Tabular Exporter")
  • chosing a field separator
  • collapsing nulls or not
  • replacing nulls with a string (using "coalesce()" function)
  • creating a new column or writing the result in the original column
  • deleting or not the source columns

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@msaby

This comment has been minimized.

Copy link
Member Author

@msaby msaby commented Aug 3, 2019

For the moment I put my js code in a new doJoinColumns column in "views/data-table/menu-edit-column.js" and the HTML in a new file "views/data-table/column-join.html".

I am not sure about the difference between "views" and "dialogs" in OR code, so maybe it is not the right place... And I don't know if the strings I will create in "translations-en" should be in "core-views" or "core-dialog" namespace. Could someone give me some precisions about that ?

@thadguidry

This comment has been minimized.

Copy link
Member

@thadguidry thadguidry commented Aug 3, 2019

These are similar ideas also expressed in our old issue #68 But we'll keep both issues around to fully understand all the wants/needs around joining options that need to be exposed for 2 or more columns. But I like the direction that you are headed with the solution description.

@msaby you can submit a "DRAFT" Pull Request to mark as a Work In Progress, that way we won't be able to merge it until you and us are comfortable and everyone has looked at the code, tested it, tried it out, etc. Draft Pull Requests are a great way to share the code while you work on it and attach it to an issue. Read more how to do that in 2 clicks here: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@msaby

This comment has been minimized.

Copy link
Member Author

@msaby msaby commented Aug 4, 2019

here it is #2110

@wetneb wetneb added this to the 3.3 milestone Aug 16, 2019
@wetneb

This comment has been minimized.

Copy link
Member

@wetneb wetneb commented Aug 16, 2019

Closed by #2110.

@wetneb wetneb closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.