Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Is your feature request related to a problem or area of OpenRefine? Please describe.
Describe the solution you'd like
Describe alternatives you've considered
For the moment I put my js code in a new doJoinColumns column in "views/data-table/menu-edit-column.js" and the HTML in a new file "views/data-table/column-join.html".
I am not sure about the difference between "views" and "dialogs" in OR code, so maybe it is not the right place... And I don't know if the strings I will create in "translations-en" should be in "core-views" or "core-dialog" namespace. Could someone give me some precisions about that ?
These are similar ideas also expressed in our old issue #68 But we'll keep both issues around to fully understand all the wants/needs around joining options that need to be exposed for 2 or more columns. But I like the direction that you are headed with the solution description.
@msaby you can submit a "DRAFT" Pull Request to mark as a Work In Progress, that way we won't be able to merge it until you and us are comfortable and everyone has looked at the code, tested it, tried it out, etc. Draft Pull Requests are a great way to share the code while you work on it and attach it to an issue. Read more how to do that in 2 clicks here: https://github.blog/2019-02-14-introducing-draft-pull-requests/