-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance cross() with empty "project name" calling parameter to represent the current project and empty column name to represent the index #2504
Comments
Hi @wetneb, @thadguidry, @ostephens, @tfmorris, @magdmartin, dear lead developers, mentors, and/or long time contributors, I respectfully ask your attention regarding this issue. Since the major enhancement of @afkbrb, once again, coded in a short period of time a PR that seams to cover the new angles of this issue without problems. There has not been a lot of tests, so that would still have to be done. But before that, since no one commented on this issue, I think it is now time to have the opinion of the community on this proposition, as to make it go forward, change it, or just drop it. In short, this issue will provide 2 enhancements to the
I think those both changes would be great enhancements. But, of course, it's up to the community to choose. In any case, we seams to be in a capacity to deliver these changes pretty soon, if the go is given. Regards, Antoine |
Oh, I forgot, this is worth mentioning (from @afkbrb in PR #2518):
So A. |
* Take snapshot of docs for version 3.4 * Versioning for docs of the cross function, for #2504 * Document 'Store archive file' option (#1963) * Remove unsupported preference from 3.4 docs (#2624) * Mention that forEach works on JSON objects (#3149) * Remove wholeText from 3.4 docs (#3180) * Document -H, /H CLI options (#3288) * Migrate Wikibase documentation from Wikidata (#1640) * Miscellanous, copy-editing
This is terrific! It’s probably worth updating some of the recipes when this is available. |
Is your feature request related to a problem or area of OpenRefine? Please describe.
The
cross()
function can get data from an external project, but also from the current project (kind of a self-join). In order to minimize the text to write (and read), if the project name parameter could be set to an empty string, it would help or visibility, and for reusability, as the SAME transformation formula can be used in 2 different projects that share some data structure (or on the same project that would have changed name since).Also, in order to be able to do a cross with the index of the row, I would let empty value for the column name. In that case, the value (first parameter of
cross()
) should be of type number.Describe the solution you'd like
if
cross()
is called with an empty project name, then it should mean that the current project is the one to use. Ex.:cross(1, "", "ID")[0]
.if
cross()
is called with an empty column name, then the cross should be done not with a column, but with the internal index of the row, in a numerical match.Describe alternatives you've considered
Writing the full column name, like now. Creating a column in the related project with the index as the value of each row.
The text was updated successfully, but these errors were encountered: