Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preference to control the choice of row quantity displayed (i.e. other than [5, 10, 25, 50]) #2624

Closed
antoine2711 opened this issue May 19, 2020 · 3 comments · Fixed by #2626
Assignees
Labels
grid pagination / scrolling About scrolling through the rows via pagination or potentially seamless scrolling Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. preferences Storage and editing of user preferences Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone

Comments

@antoine2711
Copy link
Member

antoine2711 commented May 19, 2020

Is your feature request related to a problem or area of OpenRefine? Please describe.
I would like to be able to decide what's would be my choices. A simple preference would do the trick, where I could enter: [100, 500, 1000, 5000].

Describe the solution you'd like
Set ui.gridPaginationSize = [100, 500, 1000, 5000] in the preferences.

Describe alternatives you've considered
Just more paging.

@antoine2711 antoine2711 added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. preferences Storage and editing of user preferences grid pagination / scrolling About scrolling through the rows via pagination or potentially seamless scrolling labels May 19, 2020
@antoine2711 antoine2711 self-assigned this May 19, 2020
@wetneb
Copy link
Member

wetneb commented May 19, 2020

Adding @lisa761 in the loop about this, since she is working on grid pagination. @ostephens might also have ideas how to improve this part.

@lisa761
Copy link
Member

lisa761 commented May 20, 2020

I think it's a great feature, although I am not too sure about not having a maximum limit to what this preference could be. It might affect the performance.

About the GSoC project, this would be good to have if we do keep pagination as an alternative. I was thinking of sending out a mail to both the developers and the users group about whether we should keep it or not, today.

@antoine2711
Copy link
Member Author

antoine2711 commented May 20, 2020

I think it's a great feature, although I am not too sure about not having a maximum limit to what this preference could be. It might affect the performance.

@lisa761: thanks for your comments.

You probably missed it, but in the related PR, in a comment, I said that I was going to limit to 10,000 the max. I tried it on my machine (an average machine), it takes 60 s. to load. Then, it slowly scroll. As all the burden of managing the rows is on the browser, I think this figure is pretty safe. Personally, I would stick at 1000, but I feel the user should choose. And since this feature is a prefs bound one, only savvies users will use it.

Regards,
Antoine

wetneb pushed a commit that referenced this issue Jun 18, 2020
* Add preferences for the row display quantity

Be able to control the choices for the quantity of rows displayed.

* Added _checkPaginationSize(gridPageSize, defaultGridPageSize)

Added DataTableView._checkPaginationSize(gridPageSize, defaultGridPageSize), gridPageSize = smallest size.

* Update data-table-view.js

Fix missing semi-comma.

* Fix typeof gridPageSize != "object" not working for null

Fix typeof gridPageSize != "object" not working for null

* Update data-table-view.js

* Fix tableHeader instead of headerTable

Fix tableHeader instead of headerTable
@wetneb wetneb added this to the 3.5 milestone Jun 18, 2020
@wetneb wetneb mentioned this issue Apr 24, 2021
16 tasks
wetneb added a commit to wetneb/OpenRefine that referenced this issue Apr 24, 2021
wetneb added a commit that referenced this issue May 8, 2021
* Take snapshot of docs for version 3.4

* Versioning for docs of the cross function, for #2504

* Document 'Store archive file' option (#1963)

* Remove unsupported preference from 3.4 docs (#2624)

* Mention that forEach works on JSON objects (#3149)

* Remove wholeText from 3.4 docs (#3180)

* Document -H, /H CLI options (#3288)

* Migrate Wikibase documentation from Wikidata (#1640)

* Miscellanous, copy-editing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid pagination / scrolling About scrolling through the rows via pagination or potentially seamless scrolling Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. preferences Storage and editing of user preferences Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants