Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a project from a URL - only first URL is validated #2687

Closed
tfmorris opened this issue Jun 10, 2020 · 0 comments · Fixed by #4605
Closed

Creating a project from a URL - only first URL is validated #2687

tfmorris opened this issue Jun 10, 2020 · 0 comments · Fixed by #4605
Labels
import About importers in general - add a label for the data format if available Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.6

Comments

@tfmorris
Copy link
Member

The second and subsequent URLs are not validated before they're used to attempt to create a project (as discussed in #2534)

Steps to reproduce the behavior:

  1. Go to 'Create Project' -> 'Web Addresses (URL)'
  2. Paste a valid URL (e.g. "http://api.worldbank.org/countries/all/indicators/SP.POP.TOTL?date=2000:2001")
  3. Click "Add another URL" and enter "badurl" (or any other invalid URL)
  4. Click Next
  5. See error modal dialog

Expected behavior

The value of all URL input fields should be validated to ensure that they are well-formed URLs.

OpenRefine (please complete the following information):

  • master branch (3.4 snapshot)
@tfmorris tfmorris added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jun 10, 2020
@wetneb wetneb added import About importers in general - add a label for the data format if available and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jun 10, 2020
@elebitzero elebitzero mentioned this issue Mar 10, 2022
Merged
@wetneb wetneb added this to the 3.6 milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
import About importers in general - add a label for the data format if available Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.6
Development

Successfully merging a pull request may close this issue.

Validation of all URLs in URL import elebitzero/OpenRefine
2 participants
@tfmorris @wetneb