Plurals don't work for i18n package

[tfmorris]

Describe the bug

The i18n package is missing the CLD rule parser, so plurals don't work for many languages.

To Reproduce
Per #1858 (comment)

$.i18n().locale = 'en';
$.i18n("$1 de $2 {{plural:$2|page|pages}}", 5, 10);
$.i18n().locale = 'fr';
$.i18n("$1 de $2 {{plural:$2|page|pages}}", 5, 10);

The last line gives this:

project-bundle.js:28751 Uncaught ReferenceError: pluralRuleParser is not defined
    at Object.getPluralForm (project-bundle.js:28751)
    at Object.convertPlural (project-bundle.js:28751)
    at Object.plural (project-bundle.js:28744)
    at Object.emit (project-bundle.js:28744)
    at project-bundle.js:28744
    at Function.map (project-bundle.js:504)
    at Object.emit (project-bundle.js:28744)
    at Object.parse (project-bundle.js:28739)
    at a.parse (project-bundle.js:28723)
    at Function.e.i18n (project-bundle.js:28723)

Proposed solution
Include https://github.com/santhoshtr/CLDRPluralRuleParser/blob/8baf9aedc428924fe6ee508b3d952cb5564efb3a/src/CLDRPluralRuleParser.js
(and perhaps https://github.com/santhoshtr/CLDRPluralRuleParser/blob/8baf9aedc428924fe6ee508b3d952cb5564efb3a/data/plurals.json)

(check for the appropriate version to match the version of Wikimedia i18n that we're using)

OpenRefine:

• Version 3.4 beta - current master

[antoine2711]

@tfmorris: it tested the french with this example, and it still doesn't work.

so I created a simple web page with jQuery
https://raw.githubusercontent.com/antoine2711/jQuery_i18n/master/index.html, with jQuery 3.2.1, and jQuery.i18n v1.0.7. And this works fine. But, on our codebase, jQuery v1.13.1 jQuery.fn.jquery "1.11.1", French is still not working.

But, if in file jquery.i18n.language.js, If remove the "fr" definition, then, the english fallback works fine.

So, is it possible to ask dependabot to update jQuery?

Regards,
Antoine

[thadguidry]

@antoine2711 There's a long standing issue to migrate jQuery for us... but it is now a bit more involved. Not impossible, but a bit involved. In fact, I think probably now involves a double-migration, but I could be wrong?

1st thing would be updating the jQuery migrate plugin.

• here: https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/externals/jquery-migrate-1.2.1.js
• and here: https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/MOD-INF/controller.js

If you have approximately 40 hours to spare :-) ...
You can get started reading about migrating here: https://jquery.com/upgrade-guide/3.0/

[antoine2711]

@antoine2711 There's a long standing issue to migrate jQuery for us... but it is now a bit more involved. Not impossible, but a bit involved. In fact, I think probably now involves a double-migration, but I could be wrong?

If you have approximately 40 hours to spare :-) ...
You can get started reading about migrating here: https://jquery.com/upgrade-guide/3.0/

Hi @thadguidry,
Then, since I can get the same result with deleting 3 lines in a file (If in file jquery.i18n.language.js, I remove the "fr" definition, then, the english fallback works fine), this might be a far easier path! ;-)

I wonder, before asking, I search for a jQuery issue (one who would have what you just wrote) and I didn't find one. Do you think I should create one with the data you provided here?

Regards,
Antoine