Creating a project from a URL - HTTP errors are ignored

[thadguidry]

Describe the bug
OpenRefine does not show HTTP errors when creating a project from a URL.
Instead it acts like it downloaded successfully but there is nothing shown in the preview data grid.

To Reproduce
Steps to reproduce the behavior:

1. Create new project from URL
   https://download.data.world/file_download/associatedpress/covid-impact-survey-public-data/COVID_W2_toplines.zip
2. Click on Next>>
3. No error is given
4. Preview data grid screen shows as if download completed successfully but is blank

Current Results
Preview data grid screen is blank. No HTTP error is shown to user

Expected behavior
Should not have gone to preview data grid screen because a 401 error was returned in the response.

Screenshots

Desktop:

• OS: Windows 10
• Browser Version: Firefox
• JRE or JDK Version: JDK8

OpenRefine :

• Version: OpenRefine (trunk)

[tfmorris]

I noticed this the other day and thought I created an issue, but can't find it. The status is being fetched, but then never checked.

OpenRefine/main/src/com/google/refine/importing/ImportingUtilities.java

Lines 311 to 317 in 4b146ac

	try {
	response.getStatusLine();
	HttpEntity entity = response.getEntity();
	if (entity == null) {
	throw new Exception("No content found in " + url.toString());
	}
	InputStream stream2 = entity.getContent();

This is not limited to 401. Any non-2xx status will end up using the contents of the error page without warning the user.

[urvashigupta7]

Hi, I would like to work on this issue.

[wetneb]

@urvashigupta7 fantastic! Let us know if you need any help.