Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service remove button click event propagates to underlying element #2910

Closed
VDK opened this issue Jul 8, 2020 · 4 comments · Fixed by #3168
Closed

Service remove button click event propagates to underlying element #2910

VDK opened this issue Jul 8, 2020 · 4 comments · Fixed by #3168
Assignees
@Gomaa
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.5

Comments

@VDK
Copy link
Contributor

VDK commented Jul 8, 2020

Describe the bug

When trying to remove a service the service gets selected
To Reproduce
Steps to reproduce the behavior:

  1. Reconcile ➡ Start reconcile...
  2. Click little cross symbol
  3. Service start loading

Current Results
On selecting the cross precisely (it's small) it is still the underlying element that responds. When reloading the page the old service has been removed.

Expected behavior
The service is removed, not loaded

Desktop:

  • OS: Windows
  • Browser Version: Chrome

OpenRefine :

  • Version
    OpenRefine 3.4 beta 2
@VDK VDK added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jul 8, 2020
@wetneb wetneb added Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jul 9, 2020
@sonukushwaha403
Copy link

I want to work on it

@wetneb
Copy link
Sponsor Member

wetneb commented Jul 31, 2020

Thanks! Looking forward to your PR.

@sonukushwaha403 sonukushwaha403 removed their assignment Aug 8, 2020
@Gomaa
Copy link
Contributor

Gomaa commented Sep 6, 2020

Hi there,
Can I get this issue assigned to me?

@tfmorris
Copy link
Member

tfmorris commented Sep 6, 2020

It's yours now. Good luck!

@Gomaa Gomaa mentioned this issue Sep 6, 2020
Merged
wetneb pushed a commit that referenced this issue Sep 10, 2020
@Gomaa
fix #2910: Recon service remove button also selects the service (#3168)
90d5deb 
* FIx for issue #2910 : Service remove button click event propagates to underlying element

* Use stopImmediatePropagation function to fix the issue
@wetneb wetneb added this to the 3.5 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gomaa Gomaa

Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

fixes #2910 : Service remove button click event propagates to…
5 participants
@tfmorris @wetneb @VDK @Gomaa @sonukushwaha403