Preview popup is "cropped" for items in the bottom of the screen

[pyrog]

For last rows (in the bottom of the screen), the popup is partly invisible.

Expected Behavior

Move the popup up to see it entirely

Screenshots

[tfmorris]

I'm guessing you didn't get the issue template which prompted you for all the important information.

• What version of OpenRefine?
• What browser and browser version?
• What did you do leading up to that screen capture?

... and all the other things which would help us fix this for you?

[pyrog]

To Reproduce

Steps to reproduce the behavior:

1. Display data with reconciled values
2. Display i.e. 50 lines
3. Move the mouse cursor over an item at the bottom of the web browser window
4. The popup is partially hidden

Versions

• Operating System: macOS
• Browser Version:
  • Chrome Version 84.0.4147.105 (Build officiel) (64 bits)
  • Firefox 79.0 (64 bits)
  • Safari Version 13.0.4 (14608.4.9.1.4)
• JRE or JDK Version: 1.8.0_74
• OpenRefine: Version 3.4-beta-327-g0645c2a (1)

Screenshots

[gitonthescene]

FWIW, I'm seeing this as well with OpenRefine 3.4.1, Firefox 84.0.1. These are the reconciliation preview pop-ups. I'm guessing something like this is needed.

[gitonthescene]

I think the menu is created here and the positioning is calculated here. I’ll see if I can debug the calculation from my browser when I’m at my desktop.

[EDIT: I think I see the problem. The menu is positioned before it's populated. So the height of the menu is 0 when the positioning is calculated and hence unaware that it will flow off the screen. I think flopping these lines will fix this, but I don't have a built version of OpenRefine to test it out. These seems like a nice project for a junior developer.]

[gitonthescene]

Setting up a build was easy enough. I've posted a pull request to fix this.