Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview popup is "cropped" for items in the bottom of the screen #3028

Closed
pyrog opened this issue Aug 4, 2020 · 5 comments · Fixed by #3706
Closed

Preview popup is "cropped" for items in the bottom of the screen #3028

pyrog opened this issue Aug 4, 2020 · 5 comments · Fixed by #3706
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@pyrog
Copy link

pyrog commented Aug 4, 2020

For last rows (in the bottom of the screen), the popup is partly invisible.

Expected Behavior

Move the popup up to see it entirely

Screenshots

OpenRefine - Preview popup cropped

@pyrog pyrog added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Aug 4, 2020
@tfmorris
Copy link
Member

tfmorris commented Aug 4, 2020

I'm guessing you didn't get the issue template which prompted you for all the important information.

  • What version of OpenRefine?
  • What browser and browser version?
  • What did you do leading up to that screen capture?

... and all the other things which would help us fix this for you?

@pyrog
Copy link
Author

pyrog commented Aug 4, 2020

To Reproduce

Steps to reproduce the behavior:

  1. Display data with reconciled values
  2. Display i.e. 50 lines
  3. Move the mouse cursor over an item at the bottom of the web browser window
  4. The popup is partially hidden

Versions

  • Operating System: macOS
  • Browser Version:
    • Chrome Version 84.0.4147.105 (Build officiel) (64 bits)
    • Firefox 79.0 (64 bits)
    • Safari Version 13.0.4 (14608.4.9.1.4)
  • JRE or JDK Version: 1.8.0_74
  • OpenRefine: Version 3.4-beta-327-g0645c2a (1)

Screenshots

OpenRefine popup cropped

OpenRefine popup

@gitonthescene
Copy link
Contributor

gitonthescene commented Feb 18, 2021

FWIW, I'm seeing this as well with OpenRefine 3.4.1, Firefox 84.0.1. These are the reconciliation preview pop-ups. I'm guessing something like this is needed.

@gitonthescene
Copy link
Contributor

gitonthescene commented Feb 19, 2021

I think the menu is created here and the positioning is calculated here. I’ll see if I can debug the calculation from my browser when I’m at my desktop.

[EDIT: I think I see the problem. The menu is positioned before it's populated. So the height of the menu is 0 when the positioning is calculated and hence unaware that it will flow off the screen. I think flopping these lines will fix this, but I don't have a built version of OpenRefine to test it out. These seems like a nice project for a junior developer.]

@wetneb wetneb added Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. reconciliation Related to the reconciliation operations and other features Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 19, 2021
gitonthescene pushed a commit to gitonthescene/OpenRefine that referenced this issue Mar 9, 2021
@gitonthescene
Copy link
Contributor

Setting up a build was easy enough. I've posted a pull request to fix this.

wetneb added a commit that referenced this issue Mar 10, 2021
…ning it. fixes #3028 (#3706)

Co-authored-by: Douglas Mennella <douglas.mennella@gmail.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
@wetneb wetneb added this to the 3.5 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants