Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column containing entity identifiers does not allow ENTER key press #3163

Closed
thadguidry opened this issue Sep 5, 2020 · 2 comments
Closed

Add column containing entity identifiers does not allow ENTER key press #3163

thadguidry opened this issue Sep 5, 2020 · 2 comments
Assignees
@sjathin
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.5

Comments

@thadguidry
Copy link
Member

thadguidry commented Sep 5, 2020 •
edited
Loading

Pressing ENTER key has no effect on dialog for adding a new column containing entity identifers (from the Reconcile menu)

To Reproduce

Steps to reproduce the behavior:

  1. Reconcile a few cells in a column (already done, see attached OpenRefine project to import)
  2. On Species column, choose Reconcile -> Add entity identifiers column
  3. Type in a new column name into the input box and press ENTER

Current Results

nothing more happens

Expected Behavior

I was expecting that the ENTER key was bound to the OK button and would close the dialog and my new column would appear.

Screenshots

Versions

  • Operating System: Windows
  • Browser Version: Firefox latest
  • JRE or JDK Version: JDK8
  • OpenRefine: openrefine-3.4-beta-514-gaa43445

Datasets

SCOR-Data.openrefine.tar.gz

Additional context
@thadguidry thadguidry added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. labels Sep 5, 2020
@wetneb wetneb added Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Sep 5, 2020
@sjathin
Copy link
Contributor

sjathin commented Sep 9, 2020

I would like to work on this issue.

@thadguidry
Copy link
Member Author

@sjathin Sure!

@wetneb wetneb closed this as completed in 7c0607b Sep 11, 2020
@wetneb wetneb added this to the 3.5 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjathin sjathin

Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.5
Development

No branches or pull requests
3 participants
@wetneb @thadguidry @sjathin