Skip to content

"Reconcile > Use values as identifiers" does not reconcile #3172

@allanaaa

Description

@allanaaa

To Reproduce

Run "Reconcile" > "Use values as identifiers" on any column, whether it contains properly-formatted unique IDs for the given service or not. You will see that it seems not to reconcile at all - it only says, whatever your cell contents are, it's 100% matched and generates a real-looking URL, whether or not that URL will resolve.

Expected Behavior

Reconciliation seems to be missing the part where it actually validates these unique IDs to see if they match up with existing entities. I expect failures to say so.

Screenshots

error1

I tested on Wikidata and VIAF. VIAF gives no hover-information, the matches just send you to 404s, e.g. http://viaf.org/viaf/Q17291. None of the content in that VIAF column should be matching (Q### is an invalid format) except that first value, which resolves correctly to https://viaf.org/viaf/38242123/.

There are two things happening on Wikidata that I thought I'd mention - IDs that don't exist give the error in the above screenshot. IDs that seem to exist but have yet to be assigned (something that fits the Q### format) look a bit different (so that may be a second bug to work out). I would expect these to have some other kind of obvious error message or flag.
error2

Versions

Windows, Firefox

  • OpenRefine: the new 3.4 release, as well as 3.4 beta 2 (last week)

Metadata

Metadata

Assignees

Labels

Good First IssueIndicates issues suitable for newcomers to design or coding, providing a gentle introduction.Module: FrontendThese issues involve working on HTML, CSS, and JavaScript code that affects the user interface.Type: BugIssues related to software defects or unexpected behavior, which require resolution.reconciliationRelated to the reconciliation operations and other features

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions