Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation Guess Types error causes web client to hang #3173

Closed
tfmorris opened this issue Sep 7, 2020 · 0 comments · Fixed by #3318
Closed

Reconciliation Guess Types error causes web client to hang #3173

tfmorris opened this issue Sep 7, 2020 · 0 comments · Fixed by #3318
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@tfmorris
Copy link
Member

tfmorris commented Sep 7, 2020

An error received in response to the "guess types" call at the beginning of reconciliation causes the web client to hang with the spinner up forever.

The response is of the form:

{code: "error", message: "org.apache.http.conn.HttpHostConnectException: Con…] failed: Connection refused (Connection refused)", stack: "org.apache.http.conn.HttpHostConnectException: Con…pClientConnectionOperator.java:142)↵ ... 34 more↵"}

which causes an exception: TypeError: Cannot read property 'length' of undefined
here:

self._types = data.types;
if (self._types.length === 0 && "defaultTypes" in self._service) {

Current Results

The web client gets an error and hangs with the spinner up until the page is refreshed.

Expected Behavior

The user gets a meaningful error message explaining what happened.

Additional Context

The reconciliation_service_skeleton example reconciliation service doesn't work with Python 3 and can be used to reproduce the issue.

@tfmorris tfmorris added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators reconciliation Related to the reconciliation operations and other features labels Sep 7, 2020
tfmorris added a commit to tfmorris/OpenRefine that referenced this issue Nov 5, 2020
Don't assume that the query always succeeds.
Error reporting is rudimentary (alert), but better than nothing.
wetneb pushed a commit that referenced this issue Nov 5, 2020
Don't assume that the query always succeeds.
Error reporting is rudimentary (alert), but better than nothing.
@wetneb wetneb removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Nov 5, 2020
@wetneb wetneb added this to the 3.5 milestone Nov 5, 2020
maheshjindal pushed a commit to maheshjindal/OpenRefine that referenced this issue Nov 25, 2020
…fine#3318)

Don't assume that the query always succeeds.
Error reporting is rudimentary (alert), but better than nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants