Skip to content

GREL uniques() function should preserve array order #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tfmorris opened this issue Sep 30, 2020 · 0 comments · Fixed by #3236
Closed

GREL uniques() function should preserve array order #3235

tfmorris opened this issue Sep 30, 2020 · 0 comments · Fixed by #3236
Assignees
@tfmorris
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Milestone
3.5

Comments

@tfmorris
Copy link
Member

Currently the GREL uniques() function returns the array elements in, effectively, random order. It would be more useful and predictable if the ordering were stable.

Proposed solution

Return the array in the same order as the original, but with the duplicates eliminated.
@tfmorris tfmorris added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Sep 30, 2020
@tfmorris tfmorris self-assigned this Sep 30, 2020
@tfmorris tfmorris added this to the 3.5 milestone Sep 30, 2020
tfmorris added a commit to tfmorris/OpenRefine that referenced this issue Sep 30, 2020
@tfmorris
Maintain order for uniques() - fixes OpenRefine#3235
959200d 
Also add tests
@tfmorris tfmorris mentioned this issue Sep 30, 2020
Merged
@tfmorris tfmorris removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfmorris tfmorris

Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Maintain ordering for GREL uniques() function tfmorris/OpenRefine
1 participant
@tfmorris