Skip to content

Manually selecting a reconciliation match returns the grid to page 1. #33

Closed

Description

@tfmorris

Original author: staringmonkey (May 14, 2010 14:09:53)

What steps will reproduce the problem?

  1. From the header of a data column select Reconcile -> Start Reconciling.
  2. Select and appropriate topic and click Start Reconciling.
  3. Wait for the reconcile to complete.
  4. Click the "next page" link.
  5. Find a cell that which has several possible reconciliation matches and
    click the check-mark or double-check-mark image.

What is the expected output? What do you see instead?

Reconciliation is completed correctly, however, grid is returned to page
one. This makes it nearly impossible to complete manual reconciliation for
large datasets.

What version of the product are you using? On what operating system?

SVN HEAD on OSX.

Please provide any additional information below.

Original issue: http://code.google.com/p/google-refine/issues/detail?id=33

Activity

  1. tfmorris commented on Oct 15, 2012

    @tfmorris
    MemberAuthor

    From dfhu...@gmail.com on May 14, 2010 16:32:32:
    For now, what you can do is as follows:

    • select None in the Judgment facet to see only those rows that haven't been matched.
      Or if the facet isn't there, it's available in the column's menu Reconcile -> Facets ->
      By Judgment.
    • just keep on the first page and process the first row. Once you manually match it, it
      goes away (since its judgment is no longer None).
  2. tfmorris commented on Oct 15, 2012

    @tfmorris
    MemberAuthor

    From staringmonkey on May 14, 2010 16:37:58:
    @dfhuynh That's an excellent stopgap solution--thanks for suggesting it!

  3. added
    reconciliationRelated to the reconciliation operations and other features
    on Aug 2, 2017
  4. thadguidry commented on Nov 8, 2017

    @thadguidry
    Member

    @wetneb Does this happen on your working branch any longer with Wikidata new parts ? If not, then let's close this out noting so.

  5. wetneb commented on Nov 8, 2017

    @wetneb
    Member

    @thadguidry yes this is unfortunately still current (it is not specific to freebase).

  6. ettorerizza commented on Nov 8, 2017

    @ettorerizza
    Member

    Here is a visual example. As you can see, I'm on pages 91-100. But as soon as I make a reconciliation, I come back to page 1.

    screencast2

  7. changed the title [-]Manually selecting a Freebase reconciliation match returns the grid to page 1.[/-] [+]Manually selecting a reconciliation match returns the grid to page 1.[/+] on Nov 8, 2017
  8. ostephens commented on Nov 8, 2017

    @ostephens
    SponsorMember

    See also #569 - similar issue (user is returned to start (row 1) of project), but in relation to a different action ("Apply to all identical cells" on manual cell edit)

  9. added
    Priority: MediumRepresents important issues that need to be addressed but are not urgent
    and removed
    Priority: LowIndicates less critical issues that can be dealt with at a later stage
    on Nov 8, 2017
  10. added
    Type: Feature RequestIdentifies requests for new features or enhancements. These involve proposing new improvements.
    on Mar 30, 2019
  11. thadguidry commented on Mar 30, 2019

    @thadguidry
    Member

    @wetneb @ostephens We'll use this #33 as the primary issue for the annoyance by users. I think we should open a new issue that captures the Enhancement introduction of a new "Reconcile Mode" that doesn't flip back to row 1, but keeps the Reconcile -> Facets -> By Judgement enabled with selected as "None" as the default. And that facet can't go away until they unclick "Reconcile Mode". We can also add other features to this "Reconcile Mode" as needed (some default behaviors that get enabled or some special handling).

    1. They click on a button to start "Reconcile Mode". (perhaps next to records link)
    2. User is given a message "Reconcile Mode is now ON"
    3. The By Judgement facet then shows a count of all rows selected in "none" and 0 "matched" rows.
    4. User begins reconciling with dialogs.
    5. By Judgement facet stays enabled and cannot be removed.
    6. User wants to stop "Reconcile Mode" and clicks some button and is given a message "Reconcile Mode is now OFF".
    7. By Judgement facet goes away.

    Thoughts?

  12. wetneb commented on Mar 30, 2019

    @wetneb
    Member

    I am not sure such a "Reconcile Mode" would offer much value over the current workaround: that is already what the facet does. I was thinking of a dedicated UI for matching (separate from the grid view) which would be optimized for that.

  13. thadguidry commented on Mar 30, 2019

    @thadguidry
    Member

    Then how do you propose we make this issue go away and not so frustrating for users? Oh by that dedicated UI ?

  14. wetneb commented on Mar 30, 2019

    @wetneb
    Member

    Yes. Or for this issue only, it could also be done by simply making sure the page is preserved when we apply an operation, but it might not be worth investing too much effort in that if we want to migrate to a scrollable grid in the end.

  15. 11 remaining items

  16. added this to the 4.0 milestone on Jun 29, 2023
  17. modified the milestones: 4.0, 3.9 on Oct 18, 2024
  18. magdmartin commented on Oct 23, 2024

    @magdmartin
    Member

    @tfmorris @wetneb should we re-open to remind us that this needs to be addressed in master ?

  19. wetneb commented on Oct 23, 2024

    @wetneb
    Member

    It should be addressed by #6546 which was merged in master. Are you still able to reproduce this issue on the master branch? If so, it would be worth reopening this indeed.

  20. magdmartin commented on Oct 23, 2024

    @magdmartin
    Member

    It came up as part of the user request in the survey. I wanted to link to the correct issue and provide an update on its status

  21. thadguidry commented on Oct 24, 2024

    @thadguidry
    Member

    @wetneb I'm trying to test this with master because I do think this was still happening, but not getting far today because I keep getting these console errors when trying to manually "Search for match" (typing in a wood species name, suggest finds it, I click on the QID element, then the dialog goes away, but no match is performed and I get this error):

    404 (Not Found)
    GET > https://wikidata.reconci.link/search?filter=(all%20mid:Q27684975)&output=(notable:/client/summary%20(description%20citation%20provenance)%20type)&key=null
    

    image

  22. wetneb commented on Oct 24, 2024

    @wetneb
    Member

    @thadguidry I see you have some operations undone, so you might be affected by #6746. Could you try again with the fix from #6915 applied?

  23. thadguidry commented on Oct 24, 2024

    @thadguidry
    Member

    Checked out master, then git pull https://github.com/wetneb/OpenRefine.git 6746-fix-dialog-closing

    Still the same 404 error as above in Edge browser console. It throws that 404 error in the console RIGHT WHEN I hover over any suggested QID in the drop down. If I hover over another QID in suggest dropdown that I want to manually apply, I get the repeated error in the console.
    image

  24. wetneb commented on Oct 24, 2024

    @wetneb
    Member

    @thadguidry could you open a separate issue about that then?

  25. thadguidry commented on Oct 24, 2024

    @thadguidry
    Member

    @wetneb Just tested again with a new project with 7 pages. It works fine, no matter if I click on single or double checkmark, or hover on a suggested match and click on button "Match this Cell", or choose "Search for match" and manually choose a suggested QID from dropdown. The reconciliation stays on the grid page that I am on, and I can navigate to a first or last page, or any page, manually apply a few matches, and it stays on the page I'm on.

    The above works no matter if Judgement Facet has a selection on "none" or no selection filtering.

    I'd say this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Module: FrontendThese issues involve working on HTML, CSS, and JavaScript code that affects the user interface.Priority: MediumRepresents important issues that need to be addressed but are not urgentTheme: UX/UsabilityFocuses on issues related to improving the overall user experience and interaction flow.Type: BugIssues related to software defects or unexpected behavior, which require resolution.Type: Feature RequestIdentifies requests for new features or enhancements. These involve proposing new improvements.grid pagination / scrollingAbout scrolling through the rows via pagination or potentially seamless scrollingimported from old code repoIssue imported from Google Code in 2010reconciliationRelated to the reconciliation operations and other features

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions