Make Wikibase tag configurable in the manifest

[Nikerabbit]

To Reproduce

Same as in #3354 when actually trying to save edits.

Current Results

No edits are being made.

This appears in the logs:

openrefine_1        | 16:26:03.794 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (2044ms)
openrefine_1        | 16:26:03.867 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (73ms)
openrefine_1        | 16:26:03.934 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (67ms)
openrefine_1        | 16:26:04.008 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (74ms)
openrefine_1        | 16:26:04.091 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (83ms)
openrefine_1        | 16:26:04.177 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (86ms)
openrefine_1        | 16:26:04.267 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (90ms)
openrefine_1        | 16:26:04.351 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (84ms)
openrefine_1        | 16:26:04.433 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (82ms)
openrefine_1        | 16:26:04.434 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 8203 milliseconds. (1ms)

Expected Behavior

Edits succeed or there is a clear error message in the user interface.

Screenshots

Versions

• Operating System: Debian 10
• Browser Version: Google Chrome 87.0.4280.66
• JRE or JDK Version: openjdk version "1.8.0_212"
  OpenJDK Runtime Environment (IcedTea 3.12.0) (Alpine 8.212.04-r0)
  OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
• OpenRefine: Version 3.5-beta [96789f9]
• MediaWiki: 1.35.0

Datasets

Additional context

I believe I can manually create the openrefine-3.5 change tag, and then it may work (did not test yet), but it would be nice if this was clearly documented or even better automated. If this is documented somewhere, I'll note that I did not see such a thing and I've been reading and googling stuff for a bit while debugging various issues.

Since the version number is included, it's likely to break again in the future once openrefine is updated.

[tfmorris]

That's a strange error message since there's no OpenRefine 3.5 release https://github.com/OpenRefine/OpenRefine/releases

[Nikerabbit]

Sorry, I forgot to fill in the version information, but I'm using the master branch due to #3354.

[Nikerabbit]

The edit tag is defined in

OpenRefine/extensions/wikidata/src/org/openrefine/wikidata/operations/PerformWikibaseEditsOperation.java

Lines 171 to 177 in 7d4e182

	String tag = "openrefine";
	Pattern pattern = Pattern.compile("^(\\d+\\.\\d+).*$");
	Matcher matcher = pattern.matcher(RefineServlet.VERSION);
	if (matcher.matches()) {
	tag += "-"+matcher.group(1);
	}
	this._tags = Arrays.asList(tag);

and it's just openrefine-major.minor.

[wetneb]

We should decide whether:

1. we require Wikibase instances to have a tag of the desired format (openrefine-$VERSION)
2. or we make this tag configurable in the manifest
3. or we can somehow apply the tag only if it exists in the target Wikibase instance

I am thinking 2. or 3. could work. For 3., I would try to make the first edit with the tag, and if that fails because the tag does not exist, try again without the tag (and do all further edits without the tag).