-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize casing in UI text in English #3363
Comments
This seems like a good issue to tackle as I get familiar with the UI code. I could probably resolve it sometime this week. |
Great Steve! Go for it! Appreciate all the help we can get on our issues and roadmap! |
I would like to tackle it, if @swkasica not proceeding... |
@leoshrey I am proceeding. |
Sure thing, please go ahead. |
Quick update: I'm about halfway through. End of term stuff took longer than I anticipated. Grammar is kind of tricky in UI because in addition to the normal rules of grammar and usage, there's UX specific conventions. I'm adapting these guidelines from Firefox UX on when to use different capitalization styles: title case, sentence, case, all caps, lowercase, camel case, etc... |
Hello, I am new to Open Source. I want to know if this bug is fixed? If it is fixed and merged then why is it still showing up in Issues section? If not, then can I start to work on it? Any help/feedback will be appreciated. Thankyou :) |
We should ask @swkasica first, to see if he is still working on this. |
Hi all, Sorry I haven't had time to work on this issue this month. Academic stuff has consumed all my time. To boot, my computer died a week ago and I don't have a way of running OpenRefine 😢. But I will have more free time by February 4th (and hopefully a real computer too 🤞). @SmritiSharmaBG, please feel free to work on this issue but keep me in the loop because I have done a bit of work addressing this issue. I think it requires a bit more thought than just changing the specific examples pointed out in this thread. OpenRefine currently doesn't have a set of guidelines on capitalization. So I was creating some based on the guidelines from the Firefox UX, and implementing these rules throughout the entire interface in English. These fixed the issues mentioned above, but also other areas of the interface where casing isn't consistent. |
Hi @wetneb, Is anyone working on this issue right now? |
@pvcodes what is your guess, based on the discussion above and the assignee of this issue? |
Yeah! I think @SmritiSharmaBG on it. |
I am clearing assignees to signal that this issue could be worked on. |
@weblate Now I think it is open? |
@pvcodes it's all yours! |
@wetneb So basically, I have to change the all casing to lower case for example: in SQL Exported there is a checkbox of |
@pvcodes I think you've picked an example there that should not be changed. "IF EXISTS" and "DROP" are deliberately capitalised in that case because this is the usual way of writing these statements in SQL. This is a case of checking each individual situation and making a decision - there is no single rule that can be applied across the board. The initial examples given by @wetneb are good and changes like this should be made:
@swkasica also mentioned the Firefox guidelines https://design.firefox.com/photon/copy/capitalization.html which may help guide the work. I think the general rule you can work to is "lowercase should be used except where there is a good reason for capitalisation" which is what the Firefox guidelines describe as "Sentence case". Good reasons to capitalise could include:
|
Have a look file |
it's much easier to discuss your changes if you open a pull request for them, actually :) |
Fair enough |
Hi, half of it has been done, but due to some reasons I have stop it for 2-3 days, hope you don't mind! |
No problem |
Sorry for the delay! I was an unwanted and unexpected one, I was tested positive and yesterday I'm fully recovered. Now things are coming back on track. |
Hi, @wetneb |
Hello @pvcodes, how are you doing today? Nice weather, isn't it? |
NVM, 😁 I was asking about the commit should I do PR |
Please do! |
@wetneb I would like to work on this issue. Can you assign it to me?? |
@wetneb I have a doubt. The changes made by pvcodes-zz is not merged . Is it better to make all the changes as he did and add some more changes of mine or do you want me to start from the beginning?? |
@riteshsoni123 as you prefer! It could make sense to start from #3976 since I have already reviewed that: you should only have to address the review comments there. |
We do not use a consistent casing throughout the UI.
For instance, in the "Export" menu:
In the "SQL Exporter" dialog:
Expected Behavior
We should consistently use lowercase since that is what is used in most places so far.
To solve this issue
Simply go through the existing translation files (in English) and normalize the phrases with incorrect casing.
The text was updated successfully, but these errors were encountered: