-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating exporter should have clear error reporting #3382
Comments
At the moment the error is reported in the server logs. |
Hey, I would like to work on this, I tried to reproduce this, I don't see the error reported in the server logs (always) for instance when I add an extra closing curly brace there was no error on the server logs. Please correct me if I am wrong, I think this is an issue with the parser, as it does not throw an exception when the string pattern is incorrect. |
Ah, then perhaps I was wrong in my comment above. Your observation seems to indicate that the template is parsed incorrectly, without throwing an error? |
Ok, thanks for the investigation! Feel free to assign yourself this issue if you want to work on it :) |
…exporter-error-handling
…exporter-error-handling
…exporter-error-handling
… of https://github.com/sjathin/OpenRefine into issue-OpenRefine#3382-template-exporter-error-handling
… of ssh://github.com/sjathin/OpenRefine into issue-OpenRefine#3382-template-exporter-error-handling
Currently when your code in the Templating exporter has a problem, the Preview window will just show "Updating..." forever.
It would be good to have a timeout after a few seconds and report back the line/character causing the problem. If not that, then just a generic error message would be an improvement.
When your code (inside double curly braces) isn't resolving correctly (e.g. because of an extra closing curly brace) the entire expression including the curly braces just outputs as a string instead.
This should have its own error message, instead of the string output.
The text was updated successfully, but these errors were encountered: